fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-10-09 11:08:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Bezier-rs: Add Euclidean parameterization to Bezier::evaluate (#828)

Browse Source 
* Add enum to evaluate for differenciating compute type

* Add euclidean parameterization and update styling in the UI

Co-authored-by: Rob Nadal <robnadal44@gmail.com>

* Update usage of evaluate in graphite

* Add description

* Code review changes

* Update tests

* Improve ComputeType ergonomics

* Large code review/cleanup pass

Co-authored-by: Rob Nadal <robnadal44@gmail.com>
Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Hannah Li
2022-11-18 20:37:52 -08:00
committed by Keavon Chambers
co-authored by Rob Nadal Keavon Chambers
parent a220bfa759
commit 01a9724389
15 changed files with 341 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/bezier-rs/src/bezier/core.rs
+8 -6
View File
@@ -203,6 +203,8 @@ impl Bezier {
#[cfg(test)]
mod tests {
use crate::utils::ComputeType;
use super::compare::compare_points;
use super::*;
@@ -213,13 +215,13 @@ mod tests {
let p3 = DVec2::new(160., 170.);
let bezier1 = Bezier::quadratic_through_points(p1, p2, p3, None);
assert!(compare_points(bezier1.evaluate(0.5), p2));
assert!(compare_points(bezier1.evaluate(ComputeType::Parametric(0.5)), p2));
let bezier2 = Bezier::quadratic_through_points(p1, p2, p3, Some(0.8));
assert!(compare_points(bezier2.evaluate(0.8), p2));
assert!(compare_points(bezier2.evaluate(ComputeType::Parametric(0.8)), p2));
let bezier3 = Bezier::quadratic_through_points(p1, p2, p3, Some(0.));
assert!(compare_points(bezier3.evaluate(0.), p2));
assert!(compare_points(bezier3.evaluate(ComputeType::Parametric(0.)), p2));
}
#[test]
@@ -229,12 +231,12 @@ mod tests {
let p3 = DVec2::new(160., 160.);
let bezier1 = Bezier::cubic_through_points(p1, p2, p3, Some(0.3), Some(10.));
assert!(compare_points(bezier1.evaluate(0.3), p2));
assert!(compare_points(bezier1.evaluate(ComputeType::Parametric(0.3)), p2));
let bezier2 = Bezier::cubic_through_points(p1, p2, p3, Some(0.8), Some(91.7));
assert!(compare_points(bezier2.evaluate(0.8), p2));
assert!(compare_points(bezier2.evaluate(ComputeType::Parametric(0.8)), p2));
let bezier3 = Bezier::cubic_through_points(p1, p2, p3, Some(0.), Some(91.7));
assert!(compare_points(bezier3.evaluate(0.), p2));
assert!(compare_points(bezier3.evaluate(ComputeType::Parametric(0.)), p2));
}
}