Implement dragging layers into the group/new/delete buttons in the Layers panel (#4153)

This commit is contained in:
Keavon Chambers
2026-05-15 15:39:01 -07:00
committed by GitHub
parent 79df7cfa87
commit 06e2a049de
8 changed files with 98 additions and 3 deletions
@@ -65,6 +65,10 @@
editor.widgetValueCommitAndUpdate(layoutTarget, widgets[widgetIndex].widgetId, value, resendWidget);
}
function widgetValueDragDrop(widgetIndex: number) {
editor.widgetValueDragDrop(layoutTarget, widgets[widgetIndex].widgetId);
}
// Extracts the kind and props from a Widget tagged enum, validated against the widget registry.
// The overload declares the precise correlated return type while the implementation uses broader types.
function unwrapWidget(widgetInstance: WidgetInstance): UnwrappedWidget | undefined;
@@ -175,6 +179,7 @@
getProps: (props, index) => ({
...props,
action: () => widgetValueCommitAndUpdate(index, undefined, true),
actionDragDrop: () => widgetValueDragDrop(index),
}),
},
IconLabel: {
@@ -1,4 +1,5 @@
<script lang="ts">
import { onMount, onDestroy } from "svelte";
import IconLabel from "/src/components/widgets/labels/IconLabel.svelte";
import type { IconName, IconSize } from "/src/icons";
import type { ActionShortcut } from "/wrapper/pkg/graphite_wasm_wrapper";
@@ -16,6 +17,9 @@
export let tooltipShortcut: ActionShortcut | undefined = undefined;
// Callbacks
export let action: (e?: MouseEvent) => void;
// Fired when a draggable item is dropped onto this button. Setting this also flags the button as a valid drop target
// (the consumer of the drag interaction looks for `[data-drag-droppable]` and dispatches a `dragdrop` event on it).
export let actionDragDrop: (() => void) | undefined = undefined;
let className = "";
export { className as class };
@@ -24,6 +28,14 @@
$: extraClasses = Object.entries(classes)
.flatMap(([className, stateName]) => (stateName ? [className] : []))
.join(" ");
// Element-level listener for the `dragdrop` custom event that consumers dispatch when something is dropped on this button
let buttonElement: HTMLButtonElement | undefined;
function handleDragDrop() {
actionDragDrop?.();
}
onMount(() => buttonElement?.addEventListener("dragdrop", handleDragDrop));
onDestroy(() => buttonElement?.removeEventListener("dragdrop", handleDragDrop));
</script>
<button
@@ -31,11 +43,14 @@
class:hover-icon={hoverIcon && !disabled}
class:disabled
class:emphasized
class:drag-droppable={Boolean(actionDragDrop)}
bind:this={buttonElement}
on:click={action}
{disabled}
data-tooltip-label={tooltipLabel}
data-tooltip-description={tooltipDescription}
data-tooltip-shortcut={tooltipShortcut?.shortcut ? JSON.stringify(tooltipShortcut.shortcut) : undefined}
data-drag-droppable={actionDragDrop ? "" : undefined}
tabindex={emphasized ? -1 : 0}
{...$$restProps}
>