Fix frontend HMR so the page doesn't break upon saving TS files and restructure frontend architecture (#3871)

* Clean up component setup/tear-down side effects

* Clean up more component setup/tear-down side effects

* Remove nonfunctional debouncer

* Clean up even more component setup/tear-down side effects

* Reuse backend state

* Fix HMR for IO Managers and for State Providers

* Rename IO Managers -> Managers and State Providers -> Stores

* Restructure and partially flatten managers/stores

* Code review fixes

* Review fixes
This commit is contained in:
Keavon Chambers
2026-03-19 13:38:41 -07:00
committed by GitHub
parent eb562146ce
commit 124b17f609
54 changed files with 1385 additions and 931 deletions
+37
View File
@@ -0,0 +1,37 @@
import type { Editor } from "@graphite/editor";
import { createCrashDialog } from "@graphite/stores/dialog";
let currentCleanup: (() => void) | undefined;
let currentArgs: [Editor] | undefined;
export function createPanicManager(editor: Editor) {
currentArgs = [editor];
// Code panic dialog and console error
editor.subscriptions.subscribeFrontendMessage("DisplayDialogPanic", (data) => {
// `Error.stackTraceLimit` is only available in V8/Chromium
const previousStackTraceLimit = Error.stackTraceLimit;
Error.stackTraceLimit = Infinity;
const stackTrace = new Error().stack || "";
Error.stackTraceLimit = previousStackTraceLimit;
const panicDetails = `${data.panicInfo}${stackTrace ? `\n\n${stackTrace}` : ""}`;
// eslint-disable-next-line no-console
console.error(panicDetails);
createCrashDialog(panicDetails);
});
function destroy() {
editor.subscriptions.unsubscribeFrontendMessage("DisplayDialogPanic");
}
currentCleanup = destroy;
return { destroy };
}
export type PanicManager = ReturnType<typeof createPanicManager>;
// Self-accepting HMR: tear down the old instance and re-create with the new module's code
import.meta.hot?.accept((newModule) => {
currentCleanup?.();
if (currentArgs) newModule?.createPanicManager(...currentArgs);
});