fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-10-04 10:18:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when creating cyclic nodes (#3313)

Browse Source 
* Fix crash when creating cyclic nodes

* Re-add the recursive set_input call
This commit is contained in:
James Lindsay
2025-10-30 13:01:45 +01:00
committed by GitHub
parent 40c6c6160b
commit 1b9a492a74
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/portfolio/document/utility_types/network_interface.rs
+6 -5
View File
@@ -4262,11 +4262,6 @@ impl NodeNetworkInterface {
} }
} }
let previous_metadata = match &previous_input {
NodeInput::Node { node_id, .. } => self.position(node_id, network_path).map(|position| (*node_id, position)),
_ => None,
};
let Some(network) = self.network_mut(network_path) else { let Some(network) = self.network_mut(network_path) else {
log::error!("Could not get nested network in set_input"); log::error!("Could not get nested network in set_input");
return; return;
@@ -4303,6 +4298,12 @@ impl NodeNetworkInterface {
return; return;
} }
// It is necessary to ensure the grpah is acyclic before calling `self.position` as it sometimes crashes with cyclic graphs #3227
let previous_metadata = match &previous_input {
NodeInput::Node { node_id, .. } => self.position(node_id, network_path).map(|position| (*node_id, position)),
_ => None,
};
self.transaction_modified(); self.transaction_modified();
// Ensure layer is toggled to non layer if it is no longer eligible to be a layer // Ensure layer is toggled to non layer if it is no longer eligible to be a layer