Exclude executor teardown from the measured bench regions

This commit is contained in:
Dennis Kobert
2026-08-27 10:09:18 +00:00
parent 084f14e973
commit 20e70e7bc9
3 changed files with 8 additions and 8 deletions

View File

@@ -12,9 +12,9 @@ fn run_once(c: &mut Criterion) {
bench_for_each_demo(&mut group, |name, g| {
let (_, network) = setup_network(name);
g.bench_function(name, |b| {
b.iter_batched(
b.iter_batched_ref(
|| DynamicExecutor::new(network.clone()).unwrap(),
|executor| Executor::execute(&&executor, std::hint::black_box(context)).unwrap(),
|executor| Executor::execute(&&*executor, std::hint::black_box(context)).unwrap(),
criterion::BatchSize::LargeInput,
)
});

View File

@@ -14,12 +14,12 @@ fn setup_run_once(name: &str) -> DynamicExecutor {
#[library_benchmark]
#[benches::with_setup(args = ["isometric-fountain", "painted-dreams", "procedural-string-lights", "parametric-dunescape", "red-dress", "valley-of-spires"], setup = setup_run_once)]
pub fn run_once(executor: DynamicExecutor) -> DynamicExecutor {
pub fn run_once(executor: DynamicExecutor) -> (DynamicExecutor, core_types::gpoll::GPoll<graph_craft::document::value::TaggedValue>) {
let context = application_io::RenderConfig::default();
black_box(Executor::execute(&&executor, black_box(context)).unwrap());
let result = black_box(Executor::execute(&&executor, black_box(context)).unwrap());
// Return the executor so its teardown happens outside the measured section
executor
// Return the executor and result so their teardown happens outside the measured section
(executor, result)
}
library_benchmark_group!(name = run_once_group; benchmarks = run_once);

View File

@@ -9,14 +9,14 @@ fn update_executor(c: &mut Criterion) {
let mut group = c.benchmark_group("Update Executor");
bench_for_each_demo(&mut group, |name, g| {
g.bench_function(name, |b| {
b.iter_batched(
b.iter_batched_ref(
|| {
let (_, proto_network) = setup_network(name);
let empty = ProtoNetwork::default();
let executor = DynamicExecutor::new(empty).unwrap();
(executor, proto_network)
},
|(mut executor, network)| executor.update(std::hint::black_box(network)),
|(executor, network)| executor.update(std::hint::black_box(std::mem::take(network))),
criterion::BatchSize::SmallInput,
)
});