fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-10-09 18:30:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix 'Solidify Strokes' node to produce dashed segments in an ordered sequence per open subpath (#3820)

Browse Source 
Fix the ordering of dashed segments of open paths with the 'Solidify Stroke' node
This commit is contained in:
Keavon Chambers
2026-05-17 10:56:40 -07:00
committed by GitHub
parent d5f0140f26
commit 21d2994059
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
node-graph/nodes/vector/src/vector_nodes.rs
+7 -2
View File
@@ -1197,7 +1197,9 @@ async fn solidify_stroke<T: IntoGraphicList + 'n + Send + Clone>(_: impl Ctx, #[
.with_dashes(dash_offset, dash_pattern) .with_dashes(dash_offset, dash_pattern)
.with_miter_limit(miter_limit); .with_miter_limit(miter_limit);
let stroke_options = kurbo::StrokeOpts::default(); // Pick `stable_dash_order` per subpath: closed subpaths use the default merge so the seam-spanning dash matches Vello/SVG renderers, while open subpaths use stable order so dashes are emitted in path-length sequence
let stroke_options_default = kurbo::StrokeOpts::default();
let stroke_options_stable = kurbo::StrokeOpts::default().stable_dash_order(true);
// 0.25 is balanced between performace and accuracy of the curve. // 0.25 is balanced between performace and accuracy of the curve.
const STROKE_TOLERANCE: f64 = 0.25; const STROKE_TOLERANCE: f64 = 0.25;
@@ -1205,7 +1207,10 @@ async fn solidify_stroke<T: IntoGraphicList + 'n + Send + Clone>(_: impl Ctx, #[
for mut path in bezpaths { for mut path in bezpaths {
path.apply_affine(Affine::new(stroke.transform.to_cols_array())); path.apply_affine(Affine::new(stroke.transform.to_cols_array()));
let mut solidified = kurbo::stroke(path, &stroke_style, &stroke_options, STROKE_TOLERANCE); let is_closed = matches!(path.elements().last(), Some(kurbo::PathEl::ClosePath));
let stroke_options = if is_closed { &stroke_options_default } else { &stroke_options_stable };
let mut solidified = kurbo::stroke(path, &stroke_style, stroke_options, STROKE_TOLERANCE);
if stroke.transform.matrix2.determinant() != 0. { if stroke.transform.matrix2.determinant() != 0. {
solidified.apply_affine(Affine::new(stroke.transform.inverse().to_cols_array())); solidified.apply_affine(Affine::new(stroke.transform.inverse().to_cols_array()));
} }