fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-16 06:38:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Let async source kernels write attributes through their frame claim

Browse Source
This commit is contained in:
Dennis Kobert
2026-08-29 23:00:17 +00:00
parent 84d11b9285
commit 29052a58db
5 changed files with 209 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
node-graph/node-macro/src/validation.rs
View File

@@ -44,8 +44,9 @@ fn validate_record_io(parsed: &ParsedNodeFn) {
return;
}
if parsed.is_async || crate::codegen::is_source_kernel(&parsed.output_type) {
emit_error!(parsed.output_type.span(), "attribute io is not supported on async source kernels");
let async_source = crate::codegen::classify::is_async_source(parsed);
if async_source && has_reads {
emit_error!(parsed.fn_name.span(), "attribute reads are not supported on async source kernels, only writes");
}
if crate::codegen::is_poll_kernel(&parsed.output_type) {
emit_error!(parsed.output_type.span(), "attribute io needs a plain or `Result<_, Interrupt>` kernel, not a `GPoll` one");
@@ -125,6 +126,9 @@ fn validate_record_io(parsed: &ParsedNodeFn) {
(false, ParsedFieldType::Node(NodeParsedField { output_type, .. })) if lazy_carrier => crate::codegen::unbounded_generic(parsed, output_type),
_ => None,
};
if async_source && token.is_some() {
emit_error!(carrier.pat_ident.span(), "an async source's element crosses the future boundary as a value; a passthrough generic element has none");
}
let element = writes.as_ref().map(|writes| &writes.element).unwrap_or(&value);
match &token {
Some(token) => {