fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-23 07:38:13 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix several cases of errors appearing in the console

Browse Source 
One appeared on load (a deprecated meta tag). One appeared when adding an Identity (Passthrough) node. One appeared when exposing the the Weight parameter of the Stroke node. This also fixes the intended behavior of the bisect script, which was involved when finding the prevenance of these errors.
This commit is contained in:
Keavon Chambers
2026-04-03 03:20:04 -07:00
parent 5edb00bd9a
commit 55115d89d5
4 changed files with 13 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/portfolio/document/utility_types/network_interface.rs
+6 -4
View File
@@ -3994,10 +3994,12 @@ impl NodeNetworkInterface {
self.unload_upstream_node_click_targets(vec![*node_id], network_path);
self.unload_all_nodes_bounding_box(network_path);
// Unload the interior imports ports
let nested_path = [network_path, &[*node_id]].concat();
self.unload_import_export_ports(&nested_path);
self.unload_modify_import_export(&nested_path);
// Unload the interior import/export ports if this node has a nested network
if matches!(self.implementation(node_id, network_path), Some(DocumentNodeImplementation::Network(_))) {
let nested_path = [network_path, &[*node_id]].concat();
self.unload_import_export_ports(&nested_path);
self.unload_modify_import_export(&nested_path);
}
}
} else {
self.unload_import_export_ports(network_path);
editor/src/messages/portfolio/document/utility_types/network_interface/resolved_types.rs
+4 -1
View File
@@ -242,7 +242,10 @@ impl NodeNetworkInterface {
}
DocumentNodeImplementation::ProtoNode(proto_node_identifier) => {
let Some(implementations) = NODE_REGISTRY.get(proto_node_identifier) else {
log::error!("Protonode {proto_node_identifier:?} not found in registry in potential_valid_input_types");
// The compiler removes the identity node, so it's expected to be absent from the registry
if proto_node_identifier != &graphene_std::ops::identity::IDENTIFIER {
log::error!("Proto node `{proto_node_identifier:?}` not found in the node registry, in potential_valid_input_types");
}
return Vec::new();
};
let number_of_inputs = self.number_of_inputs(node_id, network_path);