Remove dead code from document-legacy

editor/src/messages/portfolio/document/artboard/artboard_message_handler.rs

@@ -27,25 +27,21 @@ impl MessageHandler<ArtboardMessage, &PersistentData> for ArtboardMessageHandler
 		match message {
 			// Sub-messages
 			#[remain::unsorted]
-			DispatchOperation(operation) => {
-				let render_data = RenderData::new(&persistent_data.font_cache, ViewMode::Normal, None);
-
-				match self.artboards_document.handle_operation(*operation, &render_data) {
-					Ok(Some(document_responses)) => {
-						for response in document_responses {
-							match &response {
-								DocumentResponse::LayerChanged { path } => responses.add(PropertiesPanelMessage::CheckSelectedWasUpdated { path: path.clone() }),
-								DocumentResponse::DeletedLayer { path } => responses.add(PropertiesPanelMessage::CheckSelectedWasDeleted { path: path.clone() }),
-								DocumentResponse::DocumentChanged => responses.add(ArtboardMessage::RenderArtboards),
-								_ => {}
-							};
-							responses.add(BroadcastEvent::DocumentIsDirty);
-						}
+			DispatchOperation(operation) => match self.artboards_document.handle_operation(*operation) {
+				Ok(Some(document_responses)) => {
+					for response in document_responses {
+						match &response {
+							DocumentResponse::LayerChanged { path } => responses.add(PropertiesPanelMessage::CheckSelectedWasUpdated { path: path.clone() }),
+							DocumentResponse::DeletedLayer { path } => responses.add(PropertiesPanelMessage::CheckSelectedWasDeleted { path: path.clone() }),
+							DocumentResponse::DocumentChanged => responses.add(ArtboardMessage::RenderArtboards),
+							_ => {}
+						};
+						responses.add(BroadcastEvent::DocumentIsDirty);
 					}
-					Ok(None) => {}
-					Err(e) => error!("Artboard Error: {:?}", e),
 				}
-			}
+				Ok(None) => {}
+				Err(e) => error!("Artboard Error: {:?}", e),
+			},
 
 			// Messages
 			AddArtboard { id, position, size } => {

editor/src/messages/portfolio/document/document_message.rs

@@ -4,7 +4,6 @@ use crate::messages::portfolio::document::utility_types::layer_panel::LayerMetad
 use crate::messages::portfolio::document::utility_types::misc::{AlignAggregate, AlignAxis, FlipAxis};
 use crate::messages::prelude::*;
 
-use document_legacy::boolean_ops::BooleanOperation as BooleanOperationType;
 use document_legacy::document::Document as DocumentLegacy;
 use document_legacy::layers::blend_mode::BlendMode;
 use document_legacy::layers::style::ViewMode;
@@ -55,7 +54,6 @@ pub enum DocumentMessage {
 		artboard: Box<ArtboardMessageHandler>,
 		layer_metadata: HashMap<Vec<LayerId>, LayerMetadata>,
 	},
-	BooleanOperation(BooleanOperationType),
 	ClearLayerTree,
 	CommitTransaction,
 	CopyToClipboardLayerImageOutput {

editor/src/messages/portfolio/document/document_message_handler.rs

@@ -23,7 +23,6 @@ use crate::messages::prelude::*;
 use crate::messages::tool::utility_types::ToolType;
 use crate::node_graph_executor::NodeGraphExecutor;
 
-use document_legacy::boolean_ops::BooleanOperationError;
 use document_legacy::document::Document as DocumentLegacy;
 use document_legacy::layers::blend_mode::BlendMode;
 use document_legacy::layers::folder_layer::FolderLayer;
@@ -120,7 +119,7 @@ impl MessageHandler<DocumentMessage, (u64, &InputPreprocessorMessageHandler, &Pe
 			// Sub-messages
 			#[remain::unsorted]
 			DispatchOperation(op) => {
-				match self.document_legacy.handle_operation(*op, &render_data) {
+				match self.document_legacy.handle_operation(*op) {
 					Ok(Some(document_responses)) => {
 						for response in document_responses {
 							match &response {
@@ -157,13 +156,6 @@ impl MessageHandler<DocumentMessage, (u64, &InputPreprocessorMessageHandler, &Pe
 							responses.add(BroadcastEvent::DocumentIsDirty);
 						}
 					}
-					// Display boolean operation error to the user (except if it is a nothing done error).
-					Err(DocumentError::BooleanOperationError(boolean_operation_error)) if boolean_operation_error != BooleanOperationError::NothingDone => {
-						responses.add(DialogMessage::DisplayDialogError {
-							title: "Failed to calculate boolean operation".into(),
-							description: format!("Unfortunately, this feature not that robust yet.\n\nError: {boolean_operation_error:?}"),
-						})
-					}
 					Err(e) => error!("DocumentError: {:?}", e),
 					Ok(_) => (),
 				}
@@ -256,16 +248,6 @@ impl MessageHandler<DocumentMessage, (u64, &InputPreprocessorMessageHandler, &Pe
 				}
 			}
 			BackupDocument { document, artboard, layer_metadata } => self.backup_with_document(document, *artboard, layer_metadata, responses),
-			BooleanOperation(op) => {
-				// Convert Vec<&[LayerId]> to Vec<Vec<&LayerId>> because Vec<&[LayerId]> does not implement several traits (Debug, Serialize, Deserialize, ...) required by DocumentOperation enum
-				responses.add(StartTransaction);
-				responses.add(BroadcastEvent::ToolAbort);
-				responses.add(DocumentOperation::BooleanOperation {
-					operation: op,
-					selected: self.selected_layers_sorted().iter().map(|slice| (*slice).into()).collect(),
-				});
-				responses.add(CommitTransaction);
-			}
 			ClearLayerTree => {
 				// Send an empty layer tree
 				let data_buffer: RawBuffer = Self::default().serialize_root().as_slice().into();
@@ -874,8 +856,11 @@ impl MessageHandler<DocumentMessage, (u64, &InputPreprocessorMessageHandler, &Pe
 				responses.add(LayerChanged { affected_layer_path: layer_path })
 			}
 			ToggleLayerVisibility { layer_path } => {
-				responses.add(DocumentOperation::ToggleLayerVisibility { path: layer_path });
-				responses.add(BroadcastEvent::DocumentIsDirty);
+				if let Ok(layer) = self.document_legacy.layer(&layer_path) {
+					let visible = layer.visible;
+					responses.add(DocumentOperation::SetLayerVisibility { path: layer_path, visible: !visible });
+					responses.add(BroadcastEvent::DocumentIsDirty);
+				}
 			}
 			Undo => {
 				self.undo_in_progress = true;

editor/src/messages/portfolio/document/overlays/overlays_message_handler.rs

@@ -18,14 +18,10 @@ impl MessageHandler<OverlaysMessage, (bool, &PersistentData, &InputPreprocessorM
 		match message {
 			// Sub-messages
 			#[remain::unsorted]
-			DispatchOperation(operation) => {
-				let render_data = RenderData::new(&persistent_data.font_cache, ViewMode::Normal, Some(ipp.document_bounds()));
-
-				match self.overlays_document.handle_operation(*operation, &render_data) {
-					Ok(_) => responses.add(OverlaysMessage::Rerender),
-					Err(e) => error!("OverlaysError: {:?}", e),
-				}
-			}
+			DispatchOperation(operation) => match self.overlays_document.handle_operation(*operation) {
+				Ok(_) => responses.add(OverlaysMessage::Rerender),
+				Err(e) => error!("OverlaysError: {:?}", e),
+			},
 
 			// Messages
 			ClearAllOverlays => {