fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-15 22:28:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Assert the deep element glue is registered before the executor evaluates

Browse Source
This commit is contained in:
Dennis Kobert
2026-09-08 13:15:06 +00:00
parent 49daf2895e
commit 5e388cb38f
4 changed files with 29 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
node-graph/libraries/core-types/src/record/layout.rs
View File

@@ -515,8 +515,11 @@ where
if let Some(deep) = deep_element_glue(std::any::TypeId::of::<T::Static>()) {
return unsafe { (deep.clone_out)(ptr) };
}
// SAFETY: a lifetime-carrying element type registers deep glue, so
// this shallow path only erases borrow-free values.
// SAFETY: a lifetime-carrying element type registers deep glue, so this
// shallow path only erases borrow-free values. The registration is a
// whole-program convention rather than something this call can check:
// the executor asserts the in-tree types registered before it evaluates,
// which is where a missed wasm registration export is caught.
Box::new(unsafe { erase_static(read_element::<T>(Rec::new(ptr))) })
}
unsafe fn repark<T: Clone + Send + Sync + dyn_any::StaticTypeSized>(value: &(dyn std::any::Any + Send + Sync), dst: *mut u8, arena: &crate::arena::Arena) -> Option<()>

2
node-graph/libraries/core-types/src/record/mod.rs
View File

@@ -28,7 +28,7 @@ pub use layout::{
ElToken, ElementSpec, ElementWrite, ElementWritePick, ElementWritePickHashed, ElementWritePickPlain, FieldDesc, FieldOffset, FieldWrite, InputReads, Layout, LayoutMeta, RecordLayout, copy_plan,
element_dims, element_parked, element_write, element_write_hashed, empty_layout,
};
pub use owned::{OwnedRecord, deepen_field_value, register_deep_element_clone, register_deep_field_value, replay_field_value};
pub use owned::{OwnedRecord, deepen_field_value, has_deep_element_glue, register_deep_element_clone, register_deep_field_value, replay_field_value};
pub use promote::{Promotion, assert_promoted, register_element_promote, register_field_promote, register_retained_heap};
pub use route::{RecordSource, SourcePlan};
pub use run::{Group, GroupItem, RunBuilder, RunColumn, RunView};

7
node-graph/libraries/core-types/src/record/owned.rs
View File

@@ -32,6 +32,13 @@ pub(in crate::record) fn deep_element_glue(type_id: std::any::TypeId) -> Option<
DEEP_ELEMENT_CLONES.lock().unwrap().get(&type_id).copied()
}
/// Whether elements of a type registered deep glue. The shallow clone path is
/// only sound for types that did not need to, so a host that drives the
/// registration itself checks the types it owes before it evaluates anything.
pub fn has_deep_element_glue(type_id: std::any::TypeId) -> bool {
DEEP_ELEMENT_CLONES.lock().unwrap().contains_key(&type_id)
}
/// Deep-copy overrides for field values whose content borrows the
/// evaluation's arena (a graphic list holding native groups), keyed by the
/// field's owned value form. Consulted at the persistence seams only: