Refactor the old menu bar plumbing to use standard TextButtons (#3444)

* Refactor the old menu bar plumbing to use standard TextButtons

* WIP: Fix Mac native menu bar

* WIP: fix desktop menu bar mac

* Refactor menu bar definitions to use the builder pattern

* WIP: fixup desktop

* cleanup

* fix linux

* Remove dead code that was failing to lint

---------

Co-authored-by: Timon Schelling <me@timon.zip>

frontend/src/components/widgets/inputs/FontInput.svelte

@@ -84,8 +84,8 @@
 	async function getEntries(): Promise<MenuListEntry[]> {
 		const x = isStyle ? fonts.getFontStyles(fontFamily) : fonts.fontNames();
 		return (await x).map((entry: { name: string; url: URL | undefined }) => ({
-			label: entry.name,
 			value: entry.name,
+			label: entry.name,
 			font: entry.url,
 			action: () => selectFont(entry.name),
 		}));

frontend/src/components/widgets/inputs/NumberInput.svelte

@@ -110,6 +110,7 @@
 		removeEventListener("keydown", trackCtrl);
 		removeEventListener("keyup", trackCtrl);
 		removeEventListener("mousemove", trackCtrl);
+		clearTimeout(repeatTimeout);
 	});
 
 	// ===============================

frontend/src/components/widgets/inputs/RadioInput.svelte

@@ -20,8 +20,6 @@
 	function handleEntryClick(radioEntryData: RadioEntryData) {
 		const index = entries.indexOf(radioEntryData);
 		dispatch("selectedIndex", index);
-
-		radioEntryData.action?.();
 	}
 </script>
 

frontend/src/components/widgets/inputs/ScrollbarInput.svelte

@@ -203,6 +203,7 @@
 		window.removeEventListener("pointermove", onPointerMove);
 		window.removeEventListener("mousedown", onMouseDown);
 		window.removeEventListener("keydown", onKeyDown);
+		clearTimeout(repeatTimeout);
 	}
 </script>