Fix Rust code lints (#1448)

* Fix Rust lints to satisfy Clippy

* Remove some unused commented out code

node-graph/gcore/src/graphic_element.rs

@@ -1,5 +1,5 @@
 use crate::raster::{BlendMode, ImageFrame};
-use crate::vector::{subpath, VectorData};
+use crate::vector::VectorData;
 use crate::{Color, Node};
 
 use bezier_rs::BezierHandles;
@@ -231,7 +231,6 @@ impl GraphicElement {
 				let mut builder = PathBuilder::new();
 
 				let transform = to_transform(vector_data.transform);
-				let style = &vector_data.style;
 				for subpath in vector_data.subpaths.iter() {
 					let start = vector_data.transform.transform_point2(subpath[0].anchor);
 					builder.move_to(start.x as f32, start.y as f32);
@@ -300,7 +299,7 @@ impl GraphicElement {
 				group_element
 			}
 			// TODO
-			GraphicElementData::Artboard(board) => usvg::Node::new(usvg::NodeKind::Group(usvg::Group::default())),
+			GraphicElementData::Artboard(_board) => usvg::Node::new(usvg::NodeKind::Group(usvg::Group::default())),
 		}
 	}
 }

node-graph/gcore/src/raster/adjustments.rs

@@ -861,7 +861,6 @@ pub struct PosterizeNode<P> {
 fn posterize(color: Color, posterize_value: f32) -> Color {
 	let color = color.to_gamma_srgb();
 
-	let posterize_value = posterize_value;
 	let number_of_areas = posterize_value.recip();
 	let size_of_areas = (posterize_value - 1.).recip();
 	let channel = |channel: f32| (channel / number_of_areas).floor() * size_of_areas;

node-graph/gcore/src/vector/style.rs

@@ -70,12 +70,10 @@ impl Gradient {
 		let transformed_bound_transform = DAffine2::from_scale_angle_translation(transformed_bounds[1] - transformed_bounds[0], 0., transformed_bounds[0]);
 		let updated_transform = multiplied_transform * bound_transform;
 
-		let positions = self
-			.positions
-			.iter()
-			.filter_map(|(pos, color)| color.map(|color| (pos, color)))
-			.map(|(position, color)| format!(r##"<stop offset="{}" stop-color="#{}" />"##, position, color.rgba_hex()))
-			.collect::<String>();
+		let mut positions = String::new();
+		for (position, color) in self.positions.iter().filter_map(|(pos, color)| color.map(|color| (pos, color))) {
+			let _ = write!(positions, r##"<stop offset="{}" stop-color="#{}" />"##, position, color.rgba_hex());
+		}
 
 		let mod_gradient = transformed_bound_transform.inverse();
 		let mod_points = mod_gradient.inverse() * transformed_bound_transform.inverse() * updated_transform;

node-graph/graph-craft/src/document.rs

@@ -228,7 +228,7 @@ impl DocumentNode {
 			identifier: fqn,
 			input,
 			construction_args: args,
-			document_node_path: self.path.unwrap_or(Vec::new()),
+			document_node_path: self.path.unwrap_or_default(),
 			skip_deduplication: self.skip_deduplication,
 			hash: self.hash,
 		}

node-graph/gstd/src/wasm_application_io.rs

@@ -7,11 +7,11 @@ use graphene_core::raster::Image;
 use graphene_core::renderer::{GraphicElementRendered, RenderParams, SvgRender};
 use graphene_core::transform::Footprint;
 use graphene_core::vector::style::ViewMode;
+use graphene_core::Color;
 use graphene_core::{
 	raster::{color::SRGBA8, ImageFrame},
 	Node,
 };
-use graphene_core::{Color, GraphicGroup};
 #[cfg(target_arch = "wasm32")]
 use js_sys::{Object, Reflect};
 use std::collections::HashMap;
@@ -29,9 +29,6 @@ use web_sys::{CanvasRenderingContext2d, HtmlCanvasElement};
 #[cfg(feature = "wgpu")]
 use wgpu_executor::WgpuExecutor;
 
-use base64::Engine;
-use glam::DAffine2;
-
 pub struct Canvas(CanvasRenderingContext2d);
 
 #[derive(Debug, Default)]