Drop redundant conversions, assertions and struct updates

This commit is contained in:
Dennis Kobert
2026-09-09 15:39:17 +00:00
parent f726014c93
commit 6910a12f71
5 changed files with 6 additions and 9 deletions

View File

@@ -4164,9 +4164,8 @@ mod document_message_handler_tests {
.await;
// The operation completed without crashing
// Verifying application still functions by performing another operation
// Verifying application still functions by performing another operation, which panics if the folder move left the editor broken
editor.handle_message(DocumentMessage::CreateEmptyFolder).await;
assert!(true, "Application didn't crash after folder move operation");
}
// Merging nodes whose output isn't wired downstream produces an encapsulating subnetwork with no exports.

View File

@@ -69,6 +69,8 @@ impl SpiralTurns {
self.handle_state == SpiralTurnsState::Dragging
}
// Records one snapshot of the spiral's parameters; grouping them would only move the same fields into a struct
#[allow(clippy::too_many_arguments)]
pub fn store_initial_parameters(
&mut self,
layer: LayerNodeIdentifier,

View File

@@ -88,11 +88,8 @@ impl ShapeType {
}
pub fn tooltip_description(&self) -> String {
(match self {
// TODO: Add descriptions to all the shape tools
_ => "",
})
.into()
// TODO: Add descriptions to all the shape tools
String::new()
}
pub fn icon_name(&self) -> String {

View File

@@ -677,7 +677,6 @@ mod tests {
down: [10., 15.].map(|y| Rect::from_square(DVec2::new(0., y), 2.)).to_vec(),
left: [-12., -15.].map(|x| Rect::from_square(DVec2::new(x, 0.), 2.)).to_vec(),
right: [12., 15.].map(|x| Rect::from_square(DVec2::new(x, 0.), 2.)).to_vec(),
..Default::default()
};
let source = Rect::from_square(DVec2::new(0.3, 0.4), 2.);
let snap_results = &mut SnapResults::default();