fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-24 14:48:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Rename the Table type's "rows" -> "items" and "columns" -> "attributes" everywhere (#4130)

Browse Source 
* Rename TableRow -> Item

* Rename row -> item and column -> attribute throughout

* Fix a few missed ones

* Format
This commit is contained in:
Keavon Chambers
2026-05-08 23:11:33 -07:00
committed by GitHub
parent cb21e5960b
commit 6b3e4757de
26 changed files with 554 additions and 550 deletions
Download Patch File Download Diff File Expand all files Collapse all files
node-graph/nodes/text/src/lib.rs
+6 -3
View File
@@ -8,7 +8,7 @@ mod to_path;
use convert_case::{Boundary, Converter, pattern};
use core_types::graphene_hash::CacheHash;
use core_types::registry::types::{SignedInteger, TextArea};
use core_types::table::{Table, TableRow};
use core_types::table::{Item, Table};
use core_types::{CloneVarArgs, Context, Ctx, ExtractAll, ExtractVarArgs, OwnedContextImpl};
use dyn_any::DynAny;
use glam::{DAffine2, DVec2};
@@ -30,10 +30,13 @@ pub use vector_types;
pub enum TextAlign {
#[default]
#[icon("TextAlignLeft")]
#[cfg_attr(feature = "serde", serde(alias = "Left"))]
AlignLeft,
#[icon("TextAlignCenter")]
#[cfg_attr(feature = "serde", serde(alias = "Center"))]
AlignCenter,
#[icon("TextAlignRight")]
#[cfg_attr(feature = "serde", serde(alias = "Right"))]
AlignRight,
#[icon("TextJustifyLeft")]
JustifyLeft,
@@ -737,7 +740,7 @@ fn string_split(
) -> Table<String> {
let delimiter = if delimiter_escaping { unescape_string(delimiter) } else { delimiter };
string.split(&delimiter).map(str::to_string).map(TableRow::new_from_element).collect()
string.split(&delimiter).map(str::to_string).map(Item::new_from_element).collect()
}
/// Joins a list of strings together with a separator between each pair. This is the inverse of the **String Split** node.
@@ -778,7 +781,7 @@ async fn map_string(
let owned_ctx = owned_ctx.with_vararg(Box::new(string)).with_index(i);
let mapped_string = mapped.eval(owned_ctx.into_context()).await;
result.push(TableRow::new_from_element(mapped_string));
result.push(Item::new_from_element(mapped_string));
}
result