fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-15 14:18:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Drop docs naming mechanisms that do not exist

Browse Source
This commit is contained in:
Dennis Kobert
2026-09-06 15:58:40 +00:00
parent e92faf763d
commit 6cdab6b95d
5 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
node-graph/graph-craft/src/proto.rs
View File

@@ -1041,7 +1041,6 @@ fn valid_type(from: &Type, to: &Type) -> bool {
// Graphite doesn't have subtyping currently, but it used to have it, and may do so again, so we make sure to compare types in this way to make things easier. // Graphite doesn't have subtyping currently, but it used to have it, and may do so again, so we make sure to compare types in this way to make things easier.
// More details explained here: <https://github.com/GraphiteEditor/Graphite/issues/1741> // More details explained here: <https://github.com/GraphiteEditor/Graphite/issues/1741>
(Type::Fn(in1, out1), Type::Fn(in2, out2)) => valid_type(out2, out1) && valid_type(in1, in2), (Type::Fn(in1, out1), Type::Fn(in2, out2)) => valid_type(out2, out1) && valid_type(in1, in2),
// A lend input is substitutable exactly when the lent values are.
// A record input is substitutable exactly when the elements are. // A record input is substitutable exactly when the elements are.
(Type::Record(in1), Type::Record(in2)) => valid_type(in1, in2), (Type::Record(in1), Type::Record(in2)) => valid_type(in1, in2),
// If either the proposed input or the allowed input are generic, we allow the substitution (meaning this is a valid subtype). // If either the proposed input or the allowed input are generic, we allow the substitution (meaning this is a valid subtype).

3
node-graph/libraries/core-types/src/node.rs
View File

@@ -212,8 +212,7 @@ impl<'a, T> Deref for Lane<'a, T> {
} }
/// A materialized nesting level handed to a folding kernel: a thin element-typed /// A materialized nesting level handed to a folding kernel: a thin element-typed
/// view over the [`RecordBatch`] the level was collected into. The eventual /// view over the [`RecordBatch`] the level was collected into.
/// `List` once `IList` is renamed.
#[derive(Debug)] #[derive(Debug)]
pub struct List<'a, T> { pub struct List<'a, T> {
batch: RecordBatch<'a>, batch: RecordBatch<'a>,

3
node-graph/libraries/core-types/src/record/run.rs
View File

@@ -480,8 +480,7 @@ impl<T: crate::bounds::BoundingBox + dyn_any::StaticTypeSized> crate::bounds::Bo
/// Records nested inside one element: a single homogeneous run. The `row` /// Records nested inside one element: a single homogeneous run. The `row`
/// holds the group's own attribute record. A group that sits on a lane leaves /// holds the group's own attribute record. A group that sits on a lane leaves
/// it `None`, because that lane's record carries the attributes. The typed /// it `None`, because that lane's record carries the attributes.
/// segment stack returns when merge constructs segments.
#[derive(Clone, Debug)] #[derive(Clone, Debug)]
pub struct Group<'e> { pub struct Group<'e> {
pub row: Option<GroupItem<'e>>, pub row: Option<GroupItem<'e>>,

3
node-graph/node-macro/src/codegen.rs
View File

@@ -1399,8 +1399,7 @@ pub(crate) fn generate_node_impl(crate_ident: &CrateIdent, parsed: &ParsedNodeFn
} }
} }
// A flip value or a routing non-source value rides a record input; the // A flip value or a routing non-source value rides a record input; the
// element copies out into `name`. The mark/rewind that reclaims the // element copies out into `name`.
// record's frame is applied by the step lowering (see `reads_out`).
ValueBinding::RecordElement => { ValueBinding::RecordElement => {
let slot = format_ident!("__in_{index}"); let slot = format_ident!("__in_{index}");
quote! { quote! {

3
node-graph/nodes/gcore/src/record.rs
View File

@@ -171,8 +171,7 @@ fn extend_extent(base: ExtentIn<'_>, new: ExtentIn<'_>, level: LevelIn) -> GPoll
} }
} }
/// The layer-path stamp: the flip-time replacement for the Merge /// The layer-path stamp: writes the owning layer's document node path on each lane.
/// subnetwork's named attribute write.
#[node_macro::node(category("Test"))] #[node_macro::node(category("Test"))]
fn stamp_layer_path<'e, T>(ctx: impl Ctx + ExtractArena<'e>, element: T, path: Vec<NodeId>) -> Result<(T, Attr<'e, EditorLayerPath>), Interrupt> { fn stamp_layer_path<'e, T>(ctx: impl Ctx + ExtractArena<'e>, element: T, path: Vec<NodeId>) -> Result<(T, Attr<'e, EditorLayerPath>), Interrupt> {
let (parked, _) = ctx.arena().alloc(path).ok_or(GraphError { let (parked, _) = ctx.arena().alloc(path).ok_or(GraphError {