fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-17 15:28:04 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix dropdown menus spawning offset in scrolled panels, a regression from upgrading to Svelte 5.54 (#4047)

Browse Source 
* Fix dropdown menus spawning offset in scrolled panels, a regression from upgrading to Svelte 5.54

Regression introduced in #3933 by upgrading from Svelte 5.47.1 to 5.54.1

* Code review

* Fix unrelated typo

* Add assets build size to build link comment
This commit is contained in:
Keavon Chambers
2026-04-24 12:17:27 -07:00
committed by GitHub
parent c9c76df40c
commit 7bb01c9651
3 changed files with 52 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
node-graph/nodes/text/src/lib.rs
View File

@@ -682,9 +682,9 @@ fn string_length(_: impl Ctx, string: String) -> f64 {
string.graphemes(true).count() as f64
}
/// Splits a string into a list of substrings based on the specified delimeter. This is the inverse of the **String Join** node.
/// Splits a string into a list of substrings based on the specified delimiter. This is the inverse of the **String Join** node.
///
/// For example, splitting "a, b, c" with delimeter ", " produces `["a", "b", "c"]`.
/// For example, splitting "a, b, c" with delimiter ", " produces `["a", "b", "c"]`.
#[node_macro::node(category("Text"))]
fn string_split(
_: impl Ctx,
@@ -692,15 +692,15 @@ fn string_split(
string: String,
/// The character(s) that separate the substrings. These are not included in the outputs.
#[default("\\n")]
delimeter: String,
/// Whether to convert escape sequences found in the delimeter into their corresponding characters:
delimiter: String,
/// Whether to convert escape sequences found in the delimiter into their corresponding characters:
/// "\n" (newline), "\r" (carriage return), "\t" (tab), "\0" (null), and "\\" (backslash).
#[default(true)]
delimeter_escaping: bool,
delimiter_escaping: bool,
) -> Vec<String> {
let delimeter = if delimeter_escaping { unescape_string(delimeter) } else { delimeter };
let delimiter = if delimiter_escaping { unescape_string(delimiter) } else { delimiter };
string.split(&delimeter).map(str::to_string).collect()
string.split(&delimiter).map(str::to_string).collect()
}
/// Joins a list of strings together with a separator between each pair. This is the inverse of the **String Split** node.