Fix clippy lints (#1327)

* Fix clippy lints

* Update formatting

* Remove unsafe send impls

* New type for Rc<NodeContainer>

libraries/bezier-rs/Cargo.toml

@@ -14,7 +14,7 @@ repository = "https://github.com/GraphiteEditor/Graphite/tree/master/libraries/b
 documentation = "https://graphite.rs/libraries/bezier-rs/"
 
 [dependencies]
-glam = { version = "0.22", features = ["serde"] }
+glam = { version = "0.24", features = ["serde"] }
 
 dyn-any = { version = "0.3.0", path = "../dyn-any", optional = true }
 serde = { version = "1.0", features = ["derive"], optional = true }

libraries/bezier-rs/src/bezier/core.rs

@@ -209,7 +209,7 @@ impl Bezier {
 		let self_points = self.get_points().collect::<Vec<DVec2>>();
 		let other_points = other.get_points().collect::<Vec<DVec2>>();
 
-		self_points.len() == other_points.len() && self_points.into_iter().zip(other_points.into_iter()).all(|(a, b)| a.abs_diff_eq(b, max_abs_diff))
+		self_points.len() == other_points.len() && self_points.into_iter().zip(other_points).all(|(a, b)| a.abs_diff_eq(b, max_abs_diff))
 	}
 
 	/// Returns true if the start, end and handles of the Bezier are all at the same location

libraries/bezier-rs/src/bezier/transform.rs

@@ -1010,7 +1010,7 @@ mod tests {
 	fn test_arcs_cubic() {
 		let bezier = Bezier::from_cubic_coordinates(30., 30., 30., 80., 60., 80., 60., 140.);
 		let actual_arcs = bezier.arcs(ArcsOptions::default());
-		let expected_arcs = vec![
+		let expected_arcs = [
 			CircleArc {
 				center: DVec2::new(122.394877, 30.7777189),
 				radius: 92.39815,

libraries/bezier-rs/src/compare.rs

@@ -22,7 +22,7 @@ pub fn compare_points(p1: DVec2, p2: DVec2) -> bool {
 /// Compare vectors of points by allowing some maximum absolute difference to account for floating point errors
 #[cfg(test)]
 pub fn compare_vec_of_points(a: Vec<DVec2>, b: Vec<DVec2>, max_absolute_difference: f64) -> bool {
-	a.len() == b.len() && a.into_iter().zip(b.into_iter()).all(|(p1, p2)| p1.abs_diff_eq(p2, max_absolute_difference))
+	a.len() == b.len() && a.into_iter().zip(b).all(|(p1, p2)| p1.abs_diff_eq(p2, max_absolute_difference))
 }
 
 /// Compare circle arcs by allowing some maximum absolute difference between values to account for floating point errors

libraries/bezier-rs/src/utils.rs

@@ -324,7 +324,7 @@ mod tests {
 
 	/// Compare vectors of `f64`s with a provided max absolute value difference.
 	fn f64_compare_vector(vec1: Vec<f64>, vec2: Vec<f64>, max_abs_diff: f64) -> bool {
-		vec1.len() == vec2.len() && vec1.into_iter().zip(vec2.into_iter()).all(|(a, b)| f64_compare(a, b, max_abs_diff))
+		vec1.len() == vec2.len() && vec1.into_iter().zip(vec2).all(|(a, b)| f64_compare(a, b, max_abs_diff))
 	}
 
 	#[test]

libraries/dyn-any/Cargo.toml

@@ -14,7 +14,7 @@ documentation = "https://docs.rs/dyn-any"
 [dependencies]
 dyn-any-derive = { path = "derive", version = "0.3.0", optional = true }
 log = { version = "0.4", optional = true }
-glam = { version = "0.22", optional = true, default-features = false }
+glam = { version = "0.24", optional = true, default-features = false }
 
 [features]
 derive = ["dyn-any-derive"]

libraries/dyn-any/src/lib.rs

@@ -86,7 +86,7 @@ pub fn downcast<'a, V: StaticType + 'a>(i: Box<dyn DynAny<'a> + 'a>) -> Result<B
 	let type_id = DynAny::type_id(i.as_ref());
 	if type_id == core::any::TypeId::of::<<V as StaticType>::Static>() {
 		// SAFETY: caller guarantees that T is the correct type
-		let ptr = Box::into_raw(i) as *mut dyn DynAny<'a> as *mut V;
+		let ptr = Box::into_raw(i) as *mut V;
 		Ok(unsafe { Box::from_raw(ptr) })
 	} else {
 		if type_id == core::any::TypeId::of::<&dyn DynAny<'static>>() {