fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 23:38:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/dangling-01/difference.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 1 21.505442000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 1 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,16.434252000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 5.359384500000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,41.128359000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 26.811783336064,37.120515321723"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 889 B

libraries/path-bool/visual-tests/dangling-01/division.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783336064,37.120515321723 A 12.347054000000 12.347054000000 0.000000000000 0 0 30.053492000000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 27.251230395016,20.948893816326 A 8.683698700000 8.683698700000 0.000000000000 0 0 21.505442000000,29.120509958794 A 8.683698700000 8.683698700000 0.000000000000 0 0 26.811783335962,37.120515321746"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 1 21.505442000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 1 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,16.434252000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 5.359384500000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,41.128359000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 26.811783336064,37.120515321723"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.3 KiB

libraries/path-bool/visual-tests/dangling-01/exclusion.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,37.804209000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 38.872839000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,20.436811000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 1 30.053492000000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 1 26.811783336064,37.120515321723 A 8.683698700000 8.683698700000 0.000000000000 0 1 21.505442000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 1 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,16.434252000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 5.359384500000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,41.128359000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 26.811783336064,37.120515321723"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.4 KiB

libraries/path-bool/visual-tests/dangling-01/fracture.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783336064,37.120515321723 A 12.347054000000 12.347054000000 0.000000000000 0 0 30.053492000000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 27.251230395016,20.948893816326 A 8.683698700000 8.683698700000 0.000000000000 0 0 21.505442000000,29.120509958794 A 8.683698700000 8.683698700000 0.000000000000 0 0 26.811783335962,37.120515321746"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,37.804209000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 38.872839000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,20.436811000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 1 30.053492000000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 1 26.811783336064,37.120515321723"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 1 21.505442000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 1 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,16.434252000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 5.359384500000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,41.128359000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 26.811783336064,37.120515321723"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 2.0 KiB

libraries/path-bool/visual-tests/dangling-01/intersection.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783336064,37.120515321723 A 12.347054000000 12.347054000000 0.000000000000 0 0 30.053492000000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 27.251230395016,20.948893816326 A 8.683698700000 8.683698700000 0.000000000000 0 0 21.505442000000,29.120509958794 A 8.683698700000 8.683698700000 0.000000000000 0 0 26.811783335962,37.120515321746"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 720 B

libraries/path-bool/visual-tests/dangling-01/original.svg
+16
View File
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg">
<path id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="M 30.053492,28.781305 A 12.347054,12.347054 0 0 1 17.706438,41.128359 12.347054,12.347054 0 0 1 5.3593845,28.781305 12.347054,12.347054 0 0 1 17.706438,16.434252 12.347054,12.347054 0 0 1 30.053492,28.781305 Z"/>
<path id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="M 38.872839,29.12051 A 8.6836987,8.6836987 0 0 1 30.18914,37.804209 8.6836987,8.6836987 0 0 1 21.505442,29.12051 8.6836987,8.6836987 0 0 1 30.18914,20.436811 8.6836987,8.6836987 0 0 1 38.872839,29.12051 Z q 10,-10 0,-20"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 970 B

libraries/path-bool/visual-tests/dangling-01/union.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 26.811783335962,37.120515321746 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,37.804209000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 38.872839000000,29.120510000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 30.189140000000,20.436811000000 A 8.683698700000 8.683698700000 0.000000000000 0 0 27.251230394932,20.948893816238 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,16.434252000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 5.359384500000,28.781305000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 17.706438000000,41.128359000000 A 12.347054000000 12.347054000000 0.000000000000 0 0 26.811783336064,37.120515321723"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.0 KiB