fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-28 04:48:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/nesting-01/difference.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 47.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,1.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 1.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,47.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 47.000000000000,24.000000000000 M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 37.909023000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

libraries/path-bool/visual-tests/nesting-01/division.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 47.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,1.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 1.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,47.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 47.000000000000,24.000000000000 M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 37.909023000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 37.909023000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.6 KiB

libraries/path-bool/visual-tests/nesting-01/exclusion.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 47.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,1.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 1.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,47.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 47.000000000000,24.000000000000 M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 37.909023000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

libraries/path-bool/visual-tests/nesting-01/fracture.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 47.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,1.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 1.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,47.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 47.000000000000,24.000000000000 M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 1 37.909023000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 37.909023000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.6 KiB

libraries/path-bool/visual-tests/nesting-01/intersection.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 37.909023000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,10.090978000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 10.090978000000,24.000000000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 24.000000000000,37.909023000000 A 13.909023000000 13.909023000000 0.000000000000 0 0 37.909023000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 778 B

libraries/path-bool/visual-tests/nesting-01/original.svg
+25
View File
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg
width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg"
>
<defs
id="defs1"/>
<g
id="layer1">
<path
id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round"
d="M 47,24 A 23,23 0 0 1 24,47 23,23 0 0 1 1,24 23,23 0 0 1 24,1 23,23 0 0 1 47,24 Z"/>
<path
id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round"
d="M 37.909023,24 A 13.909023,13.909023 0 0 1 24,37.909023 13.909023,13.909023 0 0 1 10.090978,24 13.909023,13.909023 0 0 1 24,10.090978 13.909023,13.909023 0 0 1 37.909023,24 Z"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 949 B

libraries/path-bool/visual-tests/nesting-01/union.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round" d="M 47.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,1.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 1.000000000000,24.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 24.000000000000,47.000000000000 A 23.000000000000 23.000000000000 0.000000000000 0 0 47.000000000000,24.000000000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 776 B