fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 15:58:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/nesting-02/difference.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 0.999999940000,31.334457000000 L 0.999999940000,46.999996000000 L 47.000000000000,46.999996000000 L 47.000000000000,32.253367000000 C -79.025816000000,-5.580332600000 122.611950000000,71.818590000000 0.999999940000,31.334457000000 M 25.797222000000,29.087180000000 C 25.797222000000,30.379886000000 24.749276000000,31.427832000000 23.456570000000,31.427832000000 C 22.163863000000,31.427832000000 21.115918000000,30.379886000000 21.115918000000,29.087180000000 C 21.115918000000,27.794473000000 22.163863000000,26.746528000000 23.456570000000,26.746528000000 C 24.749276000000,26.746528000000 25.797222000000,27.794473000000 25.797222000000,29.087180000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

libraries/path-bool/visual-tests/nesting-02/division.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 0.999999940000,31.334457000000 L 0.999999940000,46.999996000000 L 47.000000000000,46.999996000000 L 47.000000000000,32.253367000000 C -79.025816000000,-5.580332600000 122.611950000000,71.818590000000 0.999999940000,31.334457000000 M 25.797222000000,29.087180000000 C 25.797222000000,30.379886000000 24.749276000000,31.427832000000 23.456570000000,31.427832000000 C 22.163863000000,31.427832000000 21.115918000000,30.379886000000 21.115918000000,29.087180000000 C 21.115918000000,27.794473000000 22.163863000000,26.746528000000 23.456570000000,26.746528000000 C 24.749276000000,26.746528000000 25.797222000000,27.794473000000 25.797222000000,29.087180000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 25.797222000000,29.087180000000 C 25.797222000000,27.794473000000 24.749276000000,26.746528000000 23.456570000000,26.746528000000 C 22.163863000000,26.746528000000 21.115918000000,27.794473000000 21.115918000000,29.087180000000 C 21.115918000000,30.379886000000 22.163863000000,31.427832000000 23.456570000000,31.427832000000 C 24.749276000000,31.427832000000 25.797222000000,30.379886000000 25.797222000000,29.087180000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.6 KiB

libraries/path-bool/visual-tests/nesting-02/exclusion.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 7.585107300000,28.332212000000 C 7.585107400000,27.039505000000 6.537161700000,25.991559000000 5.244455200000,25.991560000000 C 3.951748900000,25.991560000000 2.903803400000,27.039505000000 2.903803500000,28.332212000000 C 2.903803400000,29.624918000000 3.951748900000,30.672863000000 5.244455200000,30.672864000000 C 6.537161700000,30.672864000000 7.585107400000,29.624918000000 7.585107300000,28.332212000000 M 0.999999940000,31.334457000000 L 0.999999940000,46.999996000000 L 47.000000000000,46.999996000000 L 47.000000000000,32.253367000000 C -79.025816000000,-5.580332600000 122.611950000000,71.818590000000 0.999999940000,31.334457000000 M 25.797222000000,29.087180000000 C 25.797222000000,30.379886000000 24.749276000000,31.427832000000 23.456570000000,31.427832000000 C 22.163863000000,31.427832000000 21.115918000000,30.379886000000 21.115918000000,29.087180000000 C 21.115918000000,27.794473000000 22.163863000000,26.746528000000 23.456570000000,26.746528000000 C 24.749276000000,26.746528000000 25.797222000000,27.794473000000 25.797222000000,29.087180000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.5 KiB

libraries/path-bool/visual-tests/nesting-02/fracture.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 7.585107300000,28.332212000000 C 7.585107400000,27.039505000000 6.537161700000,25.991559000000 5.244455200000,25.991560000000 C 3.951748900000,25.991560000000 2.903803400000,27.039505000000 2.903803500000,28.332212000000 C 2.903803400000,29.624918000000 3.951748900000,30.672863000000 5.244455200000,30.672864000000 C 6.537161700000,30.672864000000 7.585107400000,29.624918000000 7.585107300000,28.332212000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 0.999999940000,31.334457000000 L 0.999999940000,46.999996000000 L 47.000000000000,46.999996000000 L 47.000000000000,32.253367000000 C -79.025816000000,-5.580332600000 122.611950000000,71.818590000000 0.999999940000,31.334457000000 M 25.797222000000,29.087180000000 C 25.797222000000,30.379886000000 24.749276000000,31.427832000000 23.456570000000,31.427832000000 C 22.163863000000,31.427832000000 21.115918000000,30.379886000000 21.115918000000,29.087180000000 C 21.115918000000,27.794473000000 22.163863000000,26.746528000000 23.456570000000,26.746528000000 C 24.749276000000,26.746528000000 25.797222000000,27.794473000000 25.797222000000,29.087180000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 25.797222000000,29.087180000000 C 25.797222000000,27.794473000000 24.749276000000,26.746528000000 23.456570000000,26.746528000000 C 22.163863000000,26.746528000000 21.115918000000,27.794473000000 21.115918000000,29.087180000000 C 21.115918000000,30.379886000000 22.163863000000,31.427832000000 23.456570000000,31.427832000000 C 24.749276000000,31.427832000000 25.797222000000,30.379886000000 25.797222000000,29.087180000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 2.2 KiB

libraries/path-bool/visual-tests/nesting-02/intersection.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 25.797222000000,29.087180000000 C 25.797222000000,27.794473000000 24.749276000000,26.746528000000 23.456570000000,26.746528000000 C 22.163863000000,26.746528000000 21.115918000000,27.794473000000 21.115918000000,29.087180000000 C 21.115918000000,30.379886000000 22.163863000000,31.427832000000 23.456570000000,31.427832000000 C 24.749276000000,31.427832000000 25.797222000000,30.379886000000 25.797222000000,29.087180000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 877 B

libraries/path-bool/visual-tests/nesting-02/original.svg
+25
View File
@@ -0,0 +1,25 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg
width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg"
xmlns:svg="http://www.w3.org/2000/svg">
<defs
id="defs1" />
<g
id="layer1">
<path
id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none"
d="M 0.99999994,31.334457 C 122.61195,71.81859 -79.025816,-5.5803326 47,32.253367 V 46.999996 H 0.99999994 Z" />
<path
id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none"
d="m 25.797222,29.08718 c 0,1.292706 -1.047946,2.340652 -2.340652,2.340652 -1.292707,0 -2.340652,-1.047946 -2.340652,-2.340652 0,-1.292707 1.047945,-2.340652 2.340652,-2.340652 1.292706,0 2.340652,1.047945 2.340652,2.340652 z M 7.5851073,28.332212 c 1e-7,1.292706 -1.0479456,2.340652 -2.3406521,2.340652 -1.2927063,-1e-6 -2.3406518,-1.047946 -2.3406517,-2.340652 -10e-8,-1.292707 1.0479454,-2.340652 2.3406517,-2.340652 1.2927065,-1e-6 2.3406522,1.047945 2.3406521,2.340652 z" />
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.2 KiB

libraries/path-bool/visual-tests/nesting-02/union.svg
+10
View File
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg" xmlns:svg="http://www.w3.org/2000/svg">
<defs id="defs1"/>
<g id="layer1">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linecap:round;stroke-linejoin:round;stroke-dasharray:none" d="M 7.585107300000,28.332212000000 C 7.585107400000,27.039505000000 6.537161700000,25.991559000000 5.244455200000,25.991560000000 C 3.951748900000,25.991560000000 2.903803400000,27.039505000000 2.903803500000,28.332212000000 C 2.903803400000,29.624918000000 3.951748900000,30.672863000000 5.244455200000,30.672864000000 C 6.537161700000,30.672864000000 7.585107400000,29.624918000000 7.585107300000,28.332212000000 M 0.999999940000,31.334457000000 L 0.999999940000,46.999996000000 L 47.000000000000,46.999996000000 L 47.000000000000,32.253367000000 C -79.025816000000,-5.580332600000 122.611950000000,71.818590000000 0.999999940000,31.334457000000"/>
</g>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB