fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 21:08:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/simple-01/difference.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 1 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,1.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 1.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661752,36.825755338450"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 815 B

libraries/path-bool/visual-tests/simple-01/division.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661752,36.825755338450 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,39.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 39.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338055,11.174244660999 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661661,36.825755338460"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 1 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,1.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 1.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661752,36.825755338450"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.4 KiB

libraries/path-bool/visual-tests/simple-01/exclusion.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,47.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 47.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 1 39.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 20.000000000000,39.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 11.174244661752,36.825755338450 A 19.000000000000 19.000000000000 0.000000000000 0 1 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,1.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 1.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661752,36.825755338450"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.3 KiB

libraries/path-bool/visual-tests/simple-01/fracture.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661752,36.825755338450 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,39.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 39.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338055,11.174244660999 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661661,36.825755338460"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,47.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 47.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 1 39.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 20.000000000000,39.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 11.174244661752,36.825755338450"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 1 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 1 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,1.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 1.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661752,36.825755338450"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 2.1 KiB

libraries/path-bool/visual-tests/simple-01/intersection.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661752,36.825755338450 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,39.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 39.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338055,11.174244660999 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,9.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 9.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661661,36.825755338460"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 817 B

libraries/path-bool/visual-tests/simple-01/original.svg
+13
View File
@@ -0,0 +1,13 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
xmlns="http://www.w3.org/2000/svg">
<path id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round"
d="M 39,20 A 19,19 0 0 1 20,39 19,19 0 0 1 1,20 19,19 0 0 1 20,1 19,19 0 0 1 39,20 Z"/>
<path id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round"
d="M 47,28 A 19,19 0 0 1 28,47 19,19 0 0 1 9,28 19,19 0 0 1 28,9 19,19 0 0 1 47,28 Z"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 618 B

libraries/path-bool/visual-tests/simple-01/union.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 11.174244661661,36.825755338460 A 19.000000000000 19.000000000000 0.000000000000 0 0 28.000000000000,47.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 47.000000000000,28.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 36.825755338461,11.174244661661 A 19.000000000000 19.000000000000 0.000000000000 0 0 20.000000000000,1.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 1.000000000000,20.000000000000 A 19.000000000000 19.000000000000 0.000000000000 0 0 11.174244661752,36.825755338450"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 817 B