fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-29 01:48:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/simple-02/difference.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,1.000000100000 L 1.000000000000,1.000000100000 L 1.000000000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,12.706436000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 519 B

libraries/path-bool/visual-tests/simple-02/division.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,1.000000100000 L 1.000000000000,1.000000100000 L 1.000000000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,12.706436000000 L 35.293564000000,12.706436000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 12.706436000000,12.706436000000 L 12.706436000000,35.293564000000 L 35.293564000000,35.293564000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 794 B

libraries/path-bool/visual-tests/simple-02/exclusion.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,1.000000100000 L 1.000000000000,1.000000100000 L 1.000000000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,12.706436000000 L 35.293564000000,12.706436000000 L 35.293564000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,47.000000000000 L 47.000000000000,47.000000000000 L 47.000000000000,12.706436000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 723 B

libraries/path-bool/visual-tests/simple-02/fracture.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,1.000000100000 L 1.000000000000,1.000000100000 L 1.000000000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,12.706436000000 L 35.293564000000,12.706436000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,47.000000000000 L 47.000000000000,47.000000000000 L 47.000000000000,12.706436000000 L 35.293564000000,12.706436000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 12.706436000000,12.706436000000 L 12.706436000000,35.293564000000 L 35.293564000000,35.293564000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

libraries/path-bool/visual-tests/simple-02/intersection.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 12.706436000000,12.706436000000 L 12.706436000000,35.293564000000 L 35.293564000000,35.293564000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 455 B

libraries/path-bool/visual-tests/simple-02/original.svg
+14
View File
@@ -0,0 +1,14 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg">
<path id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round"
d="M 1,1.0000001 H 35.293564 V 35.293564 H 1 Z"/>
<path id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round"
d="M 12.706436,12.706436 H 47 V 47 H 12.706436 Z"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 559 B

libraries/path-bool/visual-tests/simple-02/union.svg
+5
View File
@@ -0,0 +1,5 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:2;stroke-linejoin:round;stroke-linecap:round" d="M 35.293564000000,12.706436000000 L 35.293564000000,1.000000100000 L 1.000000000000,1.000000100000 L 1.000000000000,35.293564000000 L 12.706436000000,35.293564000000 L 12.706436000000,47.000000000000 L 47.000000000000,47.000000000000 L 47.000000000000,12.706436000000 L 35.293564000000,12.706436000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 587 B