fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 15:28:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/simple-06/difference.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 30.596088000000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,23.999999000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 5.088085200000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,42.010491000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 30.596088000000,33.005245000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 719 B

libraries/path-bool/visual-tests/simple-06/division.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 30.596088000000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,23.999999000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 5.088085200000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,42.010491000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 30.596088000000,33.005245000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 719 B

libraries/path-bool/visual-tests/simple-06/exclusion.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 39.958363000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,4.765773800000 A 7.147991200000 10.562863000000 0.000000000000 0 0 25.662380000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,25.891500000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 39.958363000000,15.328637000000 M 17.842086000000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,6.629647300000 A 4.408302800000 4.349494900000 0.000000000000 0 0 9.025480700000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,15.328637000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 17.842086000000,10.979142000000 M 30.596088000000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,23.999999000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 5.088085200000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,42.010491000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 30.596088000000,33.005245000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.4 KiB

libraries/path-bool/visual-tests/simple-06/fracture.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 39.958363000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,4.765773800000 A 7.147991200000 10.562863000000 0.000000000000 0 0 25.662380000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,25.891500000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 39.958363000000,15.328637000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 17.842086000000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,6.629647300000 A 4.408302800000 4.349494900000 0.000000000000 0 0 9.025480700000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,15.328637000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 17.842086000000,10.979142000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 30.596088000000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,23.999999000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 5.088085200000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,42.010491000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 30.596088000000,33.005245000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.6 KiB

libraries/path-bool/visual-tests/simple-06/intersection.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d=""/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 351 B

libraries/path-bool/visual-tests/simple-06/original.svg
+17
View File
@@ -0,0 +1,17 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg"
>
<path id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="M 30.596088,33.005245 A 12.754002,9.0052462 0 0 1 17.842087,42.010491 12.754002,9.0052462 0 0 1 5.0880852,33.005245 12.754002,9.0052462 0 0 1 17.842087,23.999999 12.754002,9.0052462 0 0 1 30.596088,33.005245 Z"/>
<path id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="m 17.842086,10.979142 a 4.4083028,4.3494949 0 0 1 -4.408302,4.349495 4.4083028,4.3494949 0 0 1 -4.4083033,-4.349495 4.4083028,4.3494949 0 0 1 4.4083033,-4.3494947 4.4083028,4.3494949 0 0 1 4.408302,4.3494947 z m 22.116277,4.349495 A 7.1479912,10.562863 0 0 1 32.810371,25.8915 7.1479912,10.562863 0 0 1 25.66238,15.328637 7.1479912,10.562863 0 0 1 32.810371,4.7657738 7.1479912,10.562863 0 0 1 39.958363,15.328637 Z"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.1 KiB

libraries/path-bool/visual-tests/simple-06/union.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 39.958363000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,4.765773800000 A 7.147991200000 10.562863000000 0.000000000000 0 0 25.662380000000,15.328637000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 32.810371000000,25.891500000000 A 7.147991200000 10.562863000000 0.000000000000 0 0 39.958363000000,15.328637000000 M 17.842086000000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,6.629647300000 A 4.408302800000 4.349494900000 0.000000000000 0 0 9.025480700000,10.979142000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 13.433784000000,15.328637000000 A 4.408302800000 4.349494900000 0.000000000000 0 0 17.842086000000,10.979142000000 M 30.596088000000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,23.999999000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 5.088085200000,33.005245000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 17.842087000000,42.010491000000 A 12.754002000000 9.005246200000 0.000000000000 0 0 30.596088000000,33.005245000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.4 KiB