fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 03:58:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Path Bool library code cleanup (#2000)

Browse Source 
* Remove log statements

* Add feature gates to functions in path.rs

* Fix infinite parsing loop and add new test

* License tweaks

* Remove trailing zero in whole number floats

* Flatten visual-tests directory

* Code review

* Clean up printlines

* Add error handling to path parsing

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Dennis Kobert
2024-09-23 12:16:31 +02:00
committed by GitHub
co-authored by Keavon Chambers
parent 3ddc052538
commit 8a1089938e
175 changed files with 442 additions and 346 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libraries/path-bool/visual-tests/simple-07/difference.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 36.977543542265,29.176233894561 36.277027059714,33.307505968268 35.564022694891,36.540471985389 C 46.041859393046,34.390449494527 48.996656660904,29.466454724495 37.671452000000,24.000000000000 M 24.000000000000,37.671452000000 C 20.702100000000,30.879219000000 10.328548000000,31.550534000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 16.450500000000,37.796429000000 24.000000000000,37.671452000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 810 B

libraries/path-bool/visual-tests/simple-07/division.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 36.977543542265,29.176233894561 36.277027059714,33.307505968268 35.564022694891,36.540471985389 C 46.041859393046,34.390449494527 48.996656660904,29.466454724495 37.671452000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 30.871598000000,20.717843000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 16.449466000000,10.328548000000 10.328548000000,16.449466000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 20.702100000000,30.879219000000 24.000000000000,37.671452000000 C 28.432011314224,37.598083135620 32.351596057547,37.199652856355 35.564022694925,36.540471985381 C 36.277027059714,33.307505968268 36.977543542265,29.176233894561 37.671452000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 24.000000000000,37.671452000000 C 20.702100000000,30.879219000000 10.328548000000,31.550534000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 16.450500000000,37.796429000000 24.000000000000,37.671452000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.5 KiB

libraries/path-bool/visual-tests/simple-07/exclusion.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 36.977543542265,29.176233894561 36.277027059714,33.307505968268 35.564022694891,36.540471985389 C 46.041859393046,34.390449494527 48.996656660904,29.466454724495 37.671452000000,24.000000000000 C 38.674677000000,16.516411000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 31.550534000000,10.328548000000 30.871598000000,20.717843000000 37.671452000000,24.000000000000 M 35.564022694925,36.540471985381 C 32.351596057547,37.199652856355 28.432011314224,37.598083135620 24.000000000000,37.671452000000 C 28.547048905111,47.036386167762 32.194946494494,51.816828488044 35.564022694891,36.540471985389 M 24.000000000000,37.671452000000 C 20.702100000000,30.879219000000 10.328548000000,31.550534000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 16.450500000000,37.796429000000 24.000000000000,37.671452000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 1.2 KiB

libraries/path-bool/visual-tests/simple-07/fracture.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 36.977543542265,29.176233894561 36.277027059714,33.307505968268 35.564022694891,36.540471985389 C 46.041859393046,34.390449494527 48.996656660904,29.466454724495 37.671452000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 30.871598000000,20.717843000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 16.449466000000,10.328548000000 10.328548000000,16.449466000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 20.702100000000,30.879219000000 24.000000000000,37.671452000000 C 28.432011314224,37.598083135620 32.351596057547,37.199652856355 35.564022694925,36.540471985381 C 36.277027059714,33.307505968268 36.977543542265,29.176233894561 37.671452000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 38.674677000000,16.516411000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 31.550534000000,10.328548000000 30.871598000000,20.717843000000 37.671452000000,24.000000000000"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 35.564022694925,36.540471985381 C 32.351596057547,37.199652856355 28.432011314224,37.598083135620 24.000000000000,37.671452000000 C 28.547048905111,47.036386167762 32.194946494494,51.816828488044 35.564022694891,36.540471985389"/><path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 24.000000000000,37.671452000000 C 20.702100000000,30.879219000000 10.328548000000,31.550534000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 16.450500000000,37.796429000000 24.000000000000,37.671452000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 2.2 KiB

libraries/path-bool/visual-tests/simple-07/intersection.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 37.671452000000,24.000000000000 C 30.871598000000,20.717843000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 16.449466000000,10.328548000000 10.328548000000,16.449466000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 20.702100000000,30.879219000000 24.000000000000,37.671452000000 C 28.432011314224,37.598083135620 32.351596057547,37.199652856355 35.564022694925,36.540471985381 C 36.277027059714,33.307505968268 36.977543542265,29.176233894561 37.671452000000,24.000000000000"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 874 B

libraries/path-bool/visual-tests/simple-07/original.svg
+16
View File
@@ -0,0 +1,16 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48"
height="48"
viewBox="0 0 48 48"
version="1.1"
id="svg1"
xmlns="http://www.w3.org/2000/svg">
<path id="a"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="M 37.671452,24 C 52.46888,31.142429 42.887716,37.358779 24,37.671452 16.4505,37.796429 10.328548,31.550534 10.328548,24 c 0,-7.550534 6.120918,-13.671452 13.671452,-13.671452 7.550534,0 6.871598,10.389295 13.671452,13.671452 z"/>
<path id="b"
style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round"
d="M 37.671452,24 C 33.698699,53.634887 29.50935,49.018306 24,37.671452 20.7021,30.879219 10.328548,31.550534 10.328548,24 c 0,-7.550534 6.120918,-13.671452 13.671452,-13.671452 7.550534,0 14.674677,6.187863 13.671452,13.671452 z"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 994 B

libraries/path-bool/visual-tests/simple-07/union.svg
+7
View File
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" standalone="no"?>
<!-- Created with Inkscape (http://www.inkscape.org/) -->
<svg width="48" height="48" viewBox="0 0 48 48" version="1.1" id="svg1" xmlns="http://www.w3.org/2000/svg">
<path style="fill:#ff0000;stroke:#000000;stroke-width:1.99937;stroke-linecap:round;stroke-linejoin:round" d="M 35.564022694925,36.540471985381 C 46.041859393046,34.390449494527 48.996656660904,29.466454724495 37.671452000000,24.000000000000 C 38.674677000000,16.516411000000 31.550534000000,10.328548000000 24.000000000000,10.328548000000 C 16.449466000000,10.328548000000 10.328548000000,16.449466000000 10.328548000000,24.000000000000 C 10.328548000000,31.550534000000 16.450500000000,37.796429000000 24.000000000000,37.671452000000 C 28.547048905111,47.036386167762 32.194946494494,51.816828488044 35.564022694891,36.540471985389"/>
</svg>
Side by Side

After

Width:  |  Height:  |  Size: 874 B