Svelte bug fixes and code cleanup (#1074)

* Fix middle click tab close

* Fix swapping colors in the ColorPicker

* Cleanup

* Fix field inputs

* Fix tab key-based navigation

* Fix ColorPicker reseting Initial color when opened

* Prevent backend fighting with user dragging NumberInput

* Remaining fixes and comment cleanup
This commit is contained in:
Keavon Chambers
2023-03-10 03:47:06 -08:00
parent 2327524690
commit 9bd319fba4
26 changed files with 220 additions and 179 deletions
@@ -33,7 +33,7 @@
let highlighted = activeEntry as MenuListEntry | undefined;
let virtualScrollingEntriesStart = 0;
// Called only when `open` is changed from outside this component (with v-model)
// Called only when `open` is changed from outside this component
$: watchOpen(open);
$: watchRemeasureWidth(entries, drawIcon);
$: virtualScrollingTotalHeight = entries.length === 0 ? 0 : entries[0].length * virtualScrollingEntryHeight;
@@ -58,7 +58,7 @@
// Call the action if available
if (menuListEntry.action) menuListEntry.action();
// Emit the clicked entry as the new active entry
// Notify the parent about the clicked entry as the new active entry
dispatch("activeEntry", menuListEntry);
// Close the containing menu