fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-10-01 12:08:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix a single layer twice selected hiding the properties (#2911)

Browse Source 
* Fix a single layer twice selected hiding the properties

* Comment that the same node appears several times

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
James Lindsay
2025-07-26 05:28:02 +00:00
committed by GitHub
co-authored by Keavon Chambers
parent 85021fd9e0
commit a1796dbc08
2 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
+6
View File
@@ -2265,6 +2265,12 @@ impl NodeGraphMessageHandler {
} }
} }
// The same layer/node may appear several times. Sort and dedup them for a stable ordering.
layers.sort();
layers.dedup();
nodes.sort();
nodes.dedup();
// Next, we decide what to display based on the number of layers and nodes selected // Next, we decide what to display based on the number of layers and nodes selected
match *layers.as_slice() { match *layers.as_slice() {
// If no layers are selected, show properties for all selected nodes // If no layers are selected, show properties for all selected nodes
editor/src/messages/portfolio/document/utility_types/nodes.rs
+2
View File
@@ -61,6 +61,7 @@ pub struct LayerPanelEntry {
pub clippable: bool, pub clippable: bool,
} }
/// IMPORTANT: the same node may appear multiple times.
#[derive(Debug, Clone, Default, serde::Serialize, serde::Deserialize, PartialEq, Eq, specta::Type)] #[derive(Debug, Clone, Default, serde::Serialize, serde::Deserialize, PartialEq, Eq, specta::Type)]
pub struct SelectedNodes(pub Vec<NodeId>); pub struct SelectedNodes(pub Vec<NodeId>);
@@ -129,6 +130,7 @@ impl SelectedNodes {
self.selected_layers(metadata).any(|selected| selected == layer) self.selected_layers(metadata).any(|selected| selected == layer)
} }
/// IMPORTANT: the same node may appear multiple times.
pub fn selected_nodes(&self) -> impl Iterator<Item = &NodeId> + '_ { pub fn selected_nodes(&self) -> impl Iterator<Item = &NodeId> + '_ {
self.0.iter() self.0.iter()
} }