fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-27 15:18:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the Gradient tool's linear/radial type toggle resetting the gradient color stops (#3499)

Browse Source 
* fix : sync the linear/radial option in menu bar and property panal

* fix : fmt

* Promote vector meshes from experimental by removing it from preferences

* fix : change reverting bug

* chore : refactor

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Jatin Bharti
2026-02-11 13:49:23 -08:00
committed by GitHub
co-authored by Keavon Chambers
parent 4cdfbb22e8
commit a1a9abd6a2
3 changed files with 65 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/portfolio/document/node_graph/node_properties.rs
+24 -24
View File
@@ -1951,35 +1951,35 @@ pub(crate) fn fill_properties(node_id: NodeId, context: &mut NodePropertiesConte
}
}
let new_gradient1 = gradient.clone();
let new_gradient2 = gradient.clone();
let gradient_for_closure = gradient.clone();
let entries = vec![
RadioEntryData::new("Linear")
.label("Linear")
.on_update(update_value(
move |_| {
let mut new_gradient = new_gradient1.clone();
new_gradient.gradient_type = GradientType::Linear;
let entries = [GradientType::Linear, GradientType::Radial]
.iter()
.map(|&grad_type| {
let gradient = gradient_for_closure.clone();
let set_input_value = update_value(
move |_: &()| {
let mut new_gradient = gradient.clone();
new_gradient.gradient_type = grad_type;
TaggedValue::Fill(Fill::Gradient(new_gradient))
},
node_id,
FillInput::<Color>::INDEX,
))
.on_commit(commit_value),
RadioEntryData::new("Radial")
.label("Radial")
.on_update(update_value(
move |_| {
let mut new_gradient = new_gradient2.clone();
new_gradient.gradient_type = GradientType::Radial;
TaggedValue::Fill(Fill::Gradient(new_gradient))
},
node_id,
FillInput::<Color>::INDEX,
))
.on_commit(commit_value),
];
);
RadioEntryData::new(format!("{:?}", grad_type))
.label(format!("{:?}", grad_type))
.on_update(move |_| Message::Batched {
messages: Box::new([
set_input_value(&()),
GradientToolMessage::UpdateOptions {
options: GradientOptionsUpdate::Type(grad_type),
}
.into(),
]),
})
.on_commit(commit_value)
})
.collect();
row.extend_from_slice(&[
Separator::new(SeparatorStyle::Unrelated).widget_instance(),