fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-24 18:38:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix the Gradient tool's linear/radial type toggle resetting the gradient color stops (#3499)

Browse Source 
* fix : sync the linear/radial option in menu bar and property panal

* fix : fmt

* Promote vector meshes from experimental by removing it from preferences

* fix : change reverting bug

* chore : refactor

---------

Co-authored-by: Keavon Chambers <keavon@keavon.com>
This commit is contained in:
Jatin Bharti
2026-02-11 13:49:23 -08:00
committed by GitHub
co-authored by Keavon Chambers
parent 4cdfbb22e8
commit a1a9abd6a2
3 changed files with 65 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/tool/tool_messages/gradient_tool.rs
+40 -9
View File
@@ -63,17 +63,48 @@ impl<'a> MessageHandler<ToolMessage, &mut ToolActionMessageContext<'a>> for Grad
match options {
GradientOptionsUpdate::Type(gradient_type) => {
self.options.gradient_type = gradient_type;
// Update the selected gradient if it exists
if let Some(selected_gradient) = &mut self.data.selected_gradient {
// Check if the current layer is a raster layer
if let Some(layer) = selected_gradient.layer {
if NodeGraphLayer::is_raster_layer(layer, &mut context.document.network_interface) {
return; // Don't proceed if it's a raster layer
let selected_layers: Vec<_> = context
.document
.network_interface
.selected_nodes()
.selected_visible_layers(&context.document.network_interface)
.collect();
let mut transaction_started = false;
for layer in selected_layers {
if NodeGraphLayer::is_raster_layer(layer, &mut context.document.network_interface) {
continue;
}
if let Some(mut gradient) = get_gradient(layer, &context.document.network_interface) {
if gradient.gradient_type != gradient_type {
if !transaction_started {
responses.add(DocumentMessage::StartTransaction);
transaction_started = true;
}
gradient.gradient_type = gradient_type;
responses.add(GraphOperationMessage::FillSet {
layer,
fill: Fill::Gradient(gradient),
});
}
selected_gradient.gradient.gradient_type = gradient_type;
selected_gradient.render_gradient(responses);
}
}
if transaction_started {
responses.add(DocumentMessage::AddTransaction);
}
if let Some(selected_gradient) = &mut self.data.selected_gradient {
if let Some(layer) = selected_gradient.layer {
if !NodeGraphLayer::is_raster_layer(layer, &mut context.document.network_interface) {
selected_gradient.gradient.gradient_type = gradient_type;
}
}
}
responses.add(ToolMessage::UpdateHints);
responses.add(PropertiesPanelMessage::Refresh);
responses.add(ToolMessage::UpdateCursor);
responses.add(ToolMessage::RefreshToolOptions);
}
}
}
@@ -104,7 +135,7 @@ impl LayoutHolder for GradientTool {
.into()
}),
])
.selected_index(Some((self.selected_gradient().unwrap_or(self.options.gradient_type) == GradientType::Radial) as u32))
.selected_index(Some((self.options.gradient_type == GradientType::Radial) as u32))
.widget_instance();
Layout(vec![LayoutGroup::Row { widgets: vec![gradient_type] }])