fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-23 08:18:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Reduce editor message size by 67% and fix simple clippy warnings (#3327)

Browse Source 
Reduce message size and fix some clippy issues
This commit is contained in:
skearya
2025-11-02 08:50:29 +01:00
committed by GitHub
parent d919dfe757
commit c4bbb7e880
9 changed files with 17 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
editor/src/messages/portfolio/document/document_message_handler.rs
+1 -1
View File
@@ -1542,7 +1542,7 @@ impl MessageHandler<DocumentMessage, DocumentMessageContext<'_>> for DocumentMes
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id,
node_template: new_artboard_node,
node_template: Box::new(new_artboard_node),
});
responses.add(NodeGraphMessage::ShiftNodePosition { node_id, x: 15, y: -3 });
responses.add(GraphOperationMessage::ResizeArtboard {
editor/src/messages/portfolio/document/node_graph/node_graph_message.rs
+2 -1
View File
@@ -75,7 +75,8 @@ pub enum NodeGraphMessage {
},
InsertNode {
node_id: NodeId,
node_template: NodeTemplate,
// Boxed to reduce size of enum (1120 bytes to 8 bytes)
node_template: Box<NodeTemplate>,
},
InsertNodeBetween {
node_id: NodeId,
editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
+3 -3
View File
@@ -264,7 +264,7 @@ impl<'a> MessageHandler<NodeGraphMessage, NodeGraphMessageContext<'a>> for NodeG
responses.add(NodeGraphMessage::InsertNode {
node_id,
node_template: node_template.clone(),
node_template: Box::new(node_template.clone()),
});
responses.add(NodeGraphMessage::ShiftNodePosition { node_id, x, y });
// Only auto connect to the dragged wire if the node is being added to the currently opened network
@@ -507,7 +507,7 @@ impl<'a> MessageHandler<NodeGraphMessage, NodeGraphMessageContext<'a>> for NodeG
responses.add(NodeGraphMessage::UpdateImportsExports);
}
NodeGraphMessage::InsertNode { node_id, node_template } => {
network_interface.insert_node(node_id, node_template, selection_network_path);
network_interface.insert_node(node_id, *node_template, selection_network_path);
}
NodeGraphMessage::InsertNodeBetween {
node_id,
@@ -624,7 +624,7 @@ impl<'a> MessageHandler<NodeGraphMessage, NodeGraphMessageContext<'a>> for NodeG
responses.add(DocumentMessage::AddTransaction);
responses.add(NodeGraphMessage::InsertNode {
node_id: encapsulating_node_id,
node_template: default_node_template,
node_template: Box::new(default_node_template),
});
responses.add(NodeGraphMessage::SetDisplayNameImpl {
node_id: encapsulating_node_id,
editor/src/messages/tool/common_functionality/graph_modification_utils.rs
+5 -5
View File
@@ -77,7 +77,7 @@ pub fn merge_layers(document: &DocumentMessageHandler, first_layer: LayerNodeIde
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id: merge_node_id,
node_template: merge_node,
node_template: Box::new(merge_node),
});
responses.add(NodeGraphMessage::SetToNodeOrLayer {
node_id: merge_node_id,
@@ -103,7 +103,7 @@ pub fn merge_layers(document: &DocumentMessageHandler, first_layer: LayerNodeIde
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id: flatten_node_id,
node_template: flatten_node,
node_template: Box::new(flatten_node),
});
responses.add(NodeGraphMessage::MoveNodeToChainStart {
node_id: flatten_node_id,
@@ -117,7 +117,7 @@ pub fn merge_layers(document: &DocumentMessageHandler, first_layer: LayerNodeIde
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id: path_node_id,
node_template: path_node,
node_template: Box::new(path_node),
});
responses.add(NodeGraphMessage::MoveNodeToChainStart {
node_id: path_node_id,
@@ -132,7 +132,7 @@ pub fn merge_layers(document: &DocumentMessageHandler, first_layer: LayerNodeIde
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id: spline_node_id,
node_template: spline_node,
node_template: Box::new(spline_node),
});
responses.add(NodeGraphMessage::MoveNodeToChainStart {
node_id: spline_node_id,
@@ -147,7 +147,7 @@ pub fn merge_layers(document: &DocumentMessageHandler, first_layer: LayerNodeIde
.default_node_template();
responses.add(NodeGraphMessage::InsertNode {
node_id: transform_node_id,
node_template: transform_node,
node_template: Box::new(transform_node),
});
responses.add(NodeGraphMessage::MoveNodeToChainStart {
node_id: transform_node_id,
editor/src/messages/tool/tool_messages/path_tool.rs
+1 -1
View File
@@ -1214,7 +1214,7 @@ impl PathToolData {
// Check if that segment exists or it has been removed
if let Some(vector_data) = document.network_interface.compute_modified_vector(layer)
&& !(vector_data.segment_domain.ids().iter().any(|segment| *segment == segment_id))
&& !(vector_data.segment_domain.ids().contains(&segment_id))
{
self.segment = None;
}