Remove serialization from Table<T> and make TaggedValue only store tooling/widget node inputs (#4129)

Browse Source

* Add TaggedValue::TypeDefault to avoid baking placeholder Tables into saved documents

* Add TaggedValue::TypeDefault to avoid baking placeholder Tables into saved documents

* Migrate empty Vector/Raster/Graphic/Artboard placeholder values to TypeDefault on load

Documents written before the TypeDefault mechanism existed have empty Table<Vector>/<Raster>/<Graphic>/<Artboard> values baked into every unwired exposed input. Walk each migrated node's inputs and rewrite any such placeholder NodeInput::Value into the equivalent NodeInput::type_default, so re-saved documents shed the placeholder payloads. Marked with a TODO for eventual removal once enough documents have been re-saved.

* Re-save demo artwork

* Remove Graphic and Artboard placeholder containers from TaggedValue

* Remove Raster placeholder TaggedValue variant

* Simplify document migration

* Remove Vector placeholder TaggedValue variant

* Remove NodeIdTable from the TaggedValue

* Remove StringTable from the TaggedValue

* Remove F64Table in place of F64Array in TaggedValue

* Replace TaggedValue::Color(Table<Color>) with ::Color(Option<Color>)

* Replace TaggedValue::GradientTable(Table<GradientStops>) with ::Gradient(GradientStops)

* Replace TaggedValue::BrushStrokeTable(Table<BrushStroke>) with ::BrushStrokes(Vec<BrushStroke>)

* Make TaggedValue::DocumentNode runtime-only with TypeDefault placeholder

* Make TaggedValue::ContextFeatures runtime-only

* Remove Serialize/Deserialize from Table<T>

* Add a widget for TaggedValue::BrushStrokes to visualize strokes and samples

* Define a reusable list of TaggedValue::TypeDefault types for its generated methods

* Re-save demo artwork

...

This commit is contained in:

Keavon Chambers

2026-05-08 16:11:25 -07:00

committed by GitHub

parent d97fe835b5

commit cb21e5960b

35 changed files with 615 additions and 937 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

demo-artwork/changing-seasons.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/isometric-fountain.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/marbled-mandelbrot.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/painted-dreams.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/parametric-dunescape.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/procedural-string-lights.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/red-dress.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long

demo-artwork/valley-of-spires.graphite

Generated

+1 -1

File diff suppressed because one or more lines are too long