Make documents fall back to "Untitled Document" (+ number suffix) if given a blank name (#4074)

* Make documents fall back to "Untitled Document" (+ number suffix) if given a blank name

* Bug fix
This commit is contained in:
Keavon Chambers
2026-04-28 18:37:13 -07:00
committed by GitHub
parent b152f46380
commit d44b0cd308
6 changed files with 43 additions and 20 deletions
@@ -784,7 +784,15 @@ impl MessageHandler<DocumentMessage, DocumentMessageContext<'_>> for DocumentMes
responses.add(EventMessage::SelectionChanged);
}
DocumentMessage::RenameDocument { new_name } => {
self.name = new_name.clone();
let new_name = new_name.trim().to_string();
// No-op when the resolved name is unchangedL committing the rename field without edits (or with
// only whitespace edits) shouldn't dissociate the document from its file on disk or mark it unsaved.
if new_name == self.name {
return;
}
self.name = new_name;
self.path = None;
self.set_save_state(false);
@@ -2475,7 +2475,7 @@ impl NodeGraphMessageHandler {
Separator::new(SeparatorStyle::Related).widget_instance(),
TextInput::new(context.document_name)
.tooltip_description("Name of the current document.")
.on_update(|text_input| DocumentMessage::RenameDocument { new_name: text_input.value.clone() }.into())
.on_update(|text_input| PortfolioMessage::RenameDocument { new_name: text_input.value.clone() }.into())
.widget_instance(),
Separator::new(SeparatorStyle::Related).widget_instance(),
])];