fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-15 22:28:10 +08:00
Code Issues Packages Projects Releases Wiki Activity

Correct docs that misstate what the code does

Browse Source
This commit is contained in:
Dennis Kobert
2026-09-06 15:58:01 +00:00
parent 305c36fb25
commit e92faf763d
8 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
node-graph/node-macro/src/codegen.rs
View File

@@ -728,7 +728,7 @@ pub(crate) struct NodePlan {
/// The field and generic derivation shared by the struct/metadata side and the
/// impl side, computed once in [`generate_node_code`] and passed to
/// [`generate_node_impl`]. `regular_fields` is the carrier-skipped slice both
/// [`generate_node_impl`]. `regular_fields` is the non-data field slice both
/// sides agree on.
pub(crate) struct NodeFields<'a> {
pub(crate) data_fields: Vec<&'a ParsedField>,
@@ -1531,8 +1531,7 @@ pub(crate) fn generate_node_impl(crate_ident: &CrateIdent, parsed: &ParsedNodeFn
});
// The extent override is the leveled `extent_at`; consumers query the
// composite `extent(ctx, Level)`, which the trait derives from it. A node
// without `extent = fn` keeps the scalar default (one item at every level).
// composite `extent(ctx, Level)`, which the trait derives from it.
// The typed extent surface: the node's inputs in declaration order (values
// readable without unsafe, inputs as per-level extent queries, derived
// content promoted per copy), then the level paired with the node's depth.

4
node-graph/node-macro/src/codegen/classify.rs
View File

@@ -120,7 +120,7 @@ pub(crate) fn routing_value_indices(regular_fields: &[&ParsedField], generic: &I
}
/// The lazy inputs declaring attribute reads, with their indices into the
/// unit-skipped regular fields.
/// regular fields.
pub(crate) fn lazy_read_fields<'a>(regular_fields: &[&'a ParsedField]) -> Vec<(usize, &'a ParsedField)> {
regular_fields
.iter()
@@ -130,7 +130,7 @@ pub(crate) fn lazy_read_fields<'a>(regular_fields: &[&'a ParsedField]) -> Vec<(u
.collect()
}
/// The indices (into the unit-skipped regular fields) of value inputs whose
/// The indices (into the regular fields) of value inputs whose
/// reads resolve against their own input rather than the carrier's.
pub(crate) fn reading_secondary_indices(regular_fields: &[&ParsedField], skips_carrier: bool) -> Vec<usize> {
regular_fields