Revamp the syntax to #[hard(a..b)] and #[soft(a..b)] bounds on node definitions (#4307)

* Revamp the syntax to #[hard(a..b)] and #[soft(a..b)] bounds on node definitions

* Address review feedback: error on empty bounds ranges and remove redundant count clamps

* Fix NaN transform from Repeat Array with a count of 1

* Remove redundant manual clamps already enforced by #[hard(...)] bounds

node-graph/nodes/repeat/src/repeat_nodes.rs

@@ -20,13 +20,13 @@ async fn repeat<T: Into<Graphic> + Default + Send + Clone + 'static>(
 	)]
 	content: impl Node<'n, Context<'static>, Output = List<T>>,
 	#[default(1)]
-	#[hard_min(1)]
+	#[hard(1..)]
 	count: u32,
 	reverse: bool,
 ) -> List<T> {
 	// Someday this node can have the option to generate infinitely instead of a fixed count (basically `std::iter::repeat`).
 
-	let count = count.max(1) as usize;
+	let count = count as usize;
 
 	let mut result_list = List::new();
 
@@ -60,12 +60,12 @@ pub async fn repeat_array<T: Into<Graphic> + Default + Send + Clone + 'static>(
 	direction: PixelSize,
 	angle: Angle,
 	#[default(5)]
-	#[hard_min(1)]
+	#[hard(1..)]
 	count: u32,
 ) -> List<T> {
 	let angle = angle.to_radians();
-	let count = count.max(1);
-	let total = (count - 1) as f64;
+	// A single copy has no steps between copies, so the denominator is kept at 1 to avoid `0. / 0.` producing a NaN transform
+	let total = (count - 1).max(1) as f64;
 
 	let mut result_list = List::new();
 
@@ -108,11 +108,9 @@ async fn repeat_radial<T: Into<Graphic> + Default + Send + Clone + 'static>(
 	#[default(5)]
 	radius: f64,
 	#[default(5)]
-	#[hard_min(1)]
+	#[hard(1..)]
 	count: u32,
 ) -> List<T> {
-	let count = count.max(1);
-
 	let mut result_list = List::new();
 
 	for index in 0..count {
@@ -265,6 +263,26 @@ mod test {
 		}
 	}
 
+	#[tokio::test]
+	async fn repeat_single_copy() {
+		let context = OwnedContextImpl::default().into_context();
+		let repeated = super::repeat_array(
+			context,
+			&FutureWrapperNode(vector_node_from_bezpath(Rect::new(0., 0., 1., 1.).to_path(DEFAULT_ACCURACY))),
+			DVec2::new(12., 10.),
+			45.,
+			1,
+		)
+		.await;
+		let vector_list = vector_nodes::flatten_path(Footprint::default(), repeated).await;
+		let vector = vector_list.element(0).unwrap();
+		assert_eq!(vector.region_manipulator_groups().count(), 1);
+
+		let (_, manipulator_groups) = vector.region_manipulator_groups().next().unwrap();
+		let anchor = manipulator_groups[0].anchor;
+		assert!(anchor.length() < 1e-5, "Expected the single copy to be untransformed, found anchor {anchor}");
+	}
+
 	#[tokio::test]
 	async fn repeat_transform_position() {
 		let direction = DVec2::new(12., 10.);