fork/Graphite
1
0
Fork 0
mirror of https://github.com/GraphiteEditor/Graphite.git synced 2026-09-16 23:08:05 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve type handling for ints/floats with the #[hard/soft_min/max(...)] node macro parameter attributes (#4041)

Browse Source
This commit is contained in:
Keavon Chambers
2026-04-23 15:49:30 -07:00
committed by GitHub
parent fcf9396a71
commit f42d12da9e
7 changed files with 114 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
node-graph/node-macro/src/validation.rs
View File

@@ -34,8 +34,8 @@ fn validate_min_max(parsed: &ParsedNodeFn) {
} = field
{
if let (Some(soft_min), Some(hard_min)) = (number_soft_min, number_hard_min) {
let soft_min_value: f64 = soft_min.base10_parse().unwrap_or_default();
let hard_min_value: f64 = hard_min.base10_parse().unwrap_or_default();
let soft_min_value: f64 = soft_min.to_f64();
let hard_min_value: f64 = hard_min.to_f64();
if soft_min_value == hard_min_value {
emit_error!(
pat_ident.span(),
@@ -56,8 +56,8 @@ fn validate_min_max(parsed: &ParsedNodeFn) {
}
if let (Some(soft_max), Some(hard_max)) = (number_soft_max, number_hard_max) {
let soft_max_value: f64 = soft_max.base10_parse().unwrap_or_default();
let hard_max_value: f64 = hard_max.base10_parse().unwrap_or_default();
let soft_max_value: f64 = soft_max.to_f64();
let hard_max_value: f64 = hard_max.to_f64();
if soft_max_value == hard_max_value {
emit_error!(
pat_ident.span(),