Code review fixes

This commit is contained in:
Adam
2025-10-04 18:59:09 -07:00
parent e6d6aa6873
commit fe7766b845
6 changed files with 5 additions and 15 deletions

View File

@@ -7,10 +7,3 @@ pub const LAYER_OUTLINE_STROKE_WEIGHT: f64 = 0.5;
// Fonts
pub const DEFAULT_FONT_FAMILY: &str = "Cabin";
pub const DEFAULT_FONT_STYLE: &str = "Regular (400)";
// Load Source Sans Pro font data
// TODO: Grab this from the node_modules folder (either with `include_bytes!` or ideally at runtime) instead of checking the font file into the repo.
// TODO: And maybe use the WOFF2 version (if it's supported) for its smaller, compressed file size.
pub const SOURCE_SANS_FONT_DATA: &[u8] = include_bytes!("text/source-sans-pro-regular.ttf");
pub const SOURCE_SANS_FONT_FAMILY: &str = "Source Sans Pro";
pub const SOURCE_SANS_FONT_STYLE: &str = "Regular (400)";

View File

@@ -70,6 +70,6 @@ impl RenderComplexity for GradientStops {
impl RenderComplexity for Typography {
fn render_complexity(&self) -> usize {
1
self.layout.lines().map(|line| line.items().count()).sum()
}
}

View File

@@ -83,7 +83,7 @@ impl fmt::Debug for Typography {
impl PartialEq for Typography {
fn eq(&self, _other: &Self) -> bool {
unimplemented!("Typography data type cannot be compared")
unimplemented!("Typography cannot be compared")
}
}