fork/cellxgene-gateway
1
0
Fork 0
mirror of https://github.com/Novartis/cellxgene-gateway.git synced 2026-10-10 04:30:55 +08:00
Code Issues Packages Projects Releases Wiki Activity

#50 fixed bug in listing subdirs

Browse Source
This commit is contained in:
Alok Saldanha
2021-07-18 09:04:36 -04:00
parent 4bf57832a0
commit 0375a717c9
2 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cellxgene_gateway/items/file/fileitem_source.py
+1 -1
View File
@@ -51,7 +51,7 @@ class FileItemSource(ItemSource):
return self.convert_h5ad_path_to_annotation(item.descriptor) return self.convert_h5ad_path_to_annotation(item.descriptor)
def list_items(self, filter: str = None) -> ItemTree: def list_items(self, filter: str = None) -> ItemTree:
item_tree = self.scan_directory() item_tree = self.scan_directory("" if filter is None else filter)
"""def get_items(dir): """def get_items(dir):
if dir.branches: if dir.branches:
tests/items/file/test_fileitem_source.py
+6 -3
View File
@@ -5,20 +5,23 @@ from unittest.mock import patch
from cellxgene_gateway.items.file.fileitem_source import FileItemSource from cellxgene_gateway.items.file.fileitem_source import FileItemSource
def stub_join(path):
path.join = lambda x, y: x + "/" + y
class TestFileItemSource(unittest.TestCase): class TestFileItemSource(unittest.TestCase):
@patch("os.path") @patch("os.path")
@patch("os.listdir") @patch("os.listdir")
def test_list_items_GIVEN_no_subpath_THEN_checks_dir(self, listdir, path): def test_list_items_GIVEN_no_subpath_THEN_checks_dir(self, listdir, path):
path.join = lambda x, y: x + "/" + y stub_join(path)
source = FileItemSource("/tmp/unittest", "local") source = FileItemSource("/tmp/unittest", "local")
source.list_items() source.list_items()
path.exists.assert_called_once_with("/tmp/unittest/") path.exists.assert_called_once_with("/tmp/unittest/")
@patch("os.path") @patch("os.path")
@patch("os.listdir") @patch("os.listdir")
@unittest.skip("fail for #50")
def test_list_items_GIVEN_subpath_THEN_checks_subpath(self, listdir, path): def test_list_items_GIVEN_subpath_THEN_checks_subpath(self, listdir, path):
path.join = lambda x, y: x + "/" + y stub_join(path)
source = FileItemSource("/tmp/unittest", "local") source = FileItemSource("/tmp/unittest", "local")
source.list_items("foo") source.list_items("foo")
path.exists.assert_called_once_with("/tmp/unittest/foo") path.exists.assert_called_once_with("/tmp/unittest/foo")