fork/cellxgene-gateway
1
0
Fork 0
mirror of https://github.com/Novartis/cellxgene-gateway.git synced 2026-10-11 05:20:56 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix AttributeError by storing ItemSource objects in default_item_source

Browse Source 
Previously, default_item_source was set to a string ("s3" or "local"),
but matching_source() tried to access default_item_source.name, causing:
  AttributeError: 'str' object has no attribute 'name'

This bug occurred when source_name=None (single data source configuration)
and has existed since the ItemSource interface was introduced in 2021.

Changes:
- Store the actual ItemSource object reference instead of string name
- Assign to intermediate variables (s3_source, file_source) for clarity

Fixes the error when viewing datasets with a single data source configured.
This commit is contained in:
Andy
2025-10-29 14:08:56 -04:00
parent 08c546f40a
commit 903d25763f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
cellxgene_gateway/gateway.py
+6 -4
View File
@@ -98,15 +98,17 @@ def initialize_data_sources():
if cellxgene_bucket is not None: if cellxgene_bucket is not None:
from cellxgene_gateway.items.s3.s3item_source import S3ItemSource from cellxgene_gateway.items.s3.s3item_source import S3ItemSource
item_sources.append(S3ItemSource(cellxgene_bucket, name="s3")) s3_source = S3ItemSource(cellxgene_bucket, name="s3")
default_item_source = "s3" item_sources.append(s3_source)
default_item_source = s3_source
logger.info("Initialized S3 data source") logger.info("Initialized S3 data source")
logger.debug(f"S3 bucket: {cellxgene_bucket}") logger.debug(f"S3 bucket: {cellxgene_bucket}")
if cellxgene_data is not None: if cellxgene_data is not None:
from cellxgene_gateway.items.file.fileitem_source import FileItemSource from cellxgene_gateway.items.file.fileitem_source import FileItemSource
item_sources.append(FileItemSource(cellxgene_data, name="local")) file_source = FileItemSource(cellxgene_data, name="local")
default_item_source = "local" item_sources.append(file_source)
default_item_source = file_source
logger.info("Initialized local file data source") logger.info("Initialized local file data source")
logger.debug(f"Data directory: {cellxgene_data}") logger.debug(f"Data directory: {cellxgene_data}")
if len(item_sources) == 0: if len(item_sources) == 0: