fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-09-27 04:28:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Better input validation (#580)

Browse Source
This commit is contained in:
Colin Megill
2019-02-05 10:44:59 -05:00
committed by GitHub
parent ad9be3cdd7
commit 08ea7d5137
1 changed files with 22 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/geneExpression/index.js
+22 -17
View File
@@ -108,21 +108,29 @@ class GeneExpression extends React.Component {
const { world, dispatch, userDefinedGenes } = this.props;
const { bulkAdd } = this.state;
const genes = _.uniq(bulkAdd.split(", ").map(g => g.trim()));
/*
test:
Apod,,, Cd74,, ,,, Foo, Bar-2,,
*/
if (bulkAdd !== "") {
const genes = _.pull(_.uniq(bulkAdd.split(/[ ,]+/)), "");
genes.forEach(gene => {
if (userDefinedGenes.indexOf(gene) !== -1) {
keepAroundErrorToast("That gene already exists");
} else if (!_.find(world.varAnnotations, { name: gene })) {
keepAroundErrorToast(`${gene} doesn't appear to be a valid gene name.`);
} else {
dispatch(actions.requestUserDefinedGene(gene));
dispatch({
type: "user defined gene",
data: gene
});
}
});
genes.forEach(gene => {
if (userDefinedGenes.indexOf(gene) !== -1) {
keepAroundErrorToast("That gene already exists");
} else if (!_.find(world.varAnnotations, { name: gene })) {
keepAroundErrorToast(
`${gene} doesn't appear to be a valid gene name.`
);
} else {
dispatch(actions.requestUserDefinedGene(gene));
dispatch({
type: "user defined gene",
data: gene
});
}
});
}
this.setState({ bulkAdd: "" });
}
@@ -230,9 +238,6 @@ class GeneExpression extends React.Component {
<FormGroup
helperText="Add a list of genes (comma delimited)"
labelFor="text-input-bulk-add"
onSubmit={() => {
console.log("heyo");
}}
>
<ControlGroup>
<InputGroup