From 096d8ff1d2196c5509c9dd175a352b9a19f88dea Mon Sep 17 00:00:00 2001
From: Colin Megill <colinmegill@gmail.com>
Date: Wed, 5 May 2021 16:51:05 -0700
Subject: [PATCH] Geneset remove toggle (#2184)

* no toggle, histo at top

* set mean expression, truncation

* gene set
---
 .../components/brushableHistogram/footer.js   |  4 +-
 .../components/brushableHistogram/index.js    |  6 +-
 .../src/components/geneExpression/geneSet.js  | 60 ++++---------------
 .../geneExpression/menus/genesetMenus.js      | 16 +----
 4 files changed, 20 insertions(+), 66 deletions(-)

diff --git a/client/src/components/brushableHistogram/footer.js b/client/src/components/brushableHistogram/footer.js
index 39e800f2..ab5d5a4f 100644
--- a/client/src/components/brushableHistogram/footer.js
+++ b/client/src/components/brushableHistogram/footer.js
@@ -11,6 +11,7 @@ const HistogramFooter = React.memo(
     logFoldChange,
     pvalAdj,
     isObs,
+    isGeneSetSummary,
   }) => {
     /*
     Footer of each histogram.  Will render range, title, and optionally 
@@ -44,7 +45,8 @@ const HistogramFooter = React.memo(
             data-testclass="brushable-histogram-field-name"
             style={{ fontStyle: "italic" }}
           >
-            {isObs ? displayName : null}
+            {isObs && displayName}
+            {isGeneSetSummary && "gene set mean expression"}
           </span>
           <div style={{ display: hideRanges ? "block" : "none" }}>
             : {rangeMin}
diff --git a/client/src/components/brushableHistogram/index.js b/client/src/components/brushableHistogram/index.js
index 277b1c01..754d9a0f 100644
--- a/client/src/components/brushableHistogram/index.js
+++ b/client/src/components/brushableHistogram/index.js
@@ -364,6 +364,7 @@ class HistogramBrush extends React.PureComponent {
       isUserDefined,
       isDiffExp,
       logFoldChange,
+      isGeneSetSummary,
       pvalAdj,
       isScatterplotXXaccessor,
       isScatterplotYYaccessor,
@@ -449,8 +450,9 @@ class HistogramBrush extends React.PureComponent {
                   selectionRange={continuousSelectionRange}
                   mini={mini}
                 />
-                {!mini ? (
+                {!mini && (
                   <HistogramFooter
+                    isGeneSetSummary={isGeneSetSummary}
                     isObs={isObs}
                     isDiffExp={isDiffExp}
                     displayName={field}
@@ -462,7 +464,7 @@ class HistogramBrush extends React.PureComponent {
                     logFoldChange={logFoldChange}
                     pvalAdj={pvalAdj}
                   />
-                ) : null}
+                )}
               </div>
             ) : null
           }
diff --git a/client/src/components/geneExpression/geneSet.js b/client/src/components/geneExpression/geneSet.js
index 23614a87..b13899cc 100644
--- a/client/src/components/geneExpression/geneSet.js
+++ b/client/src/components/geneExpression/geneSet.js
@@ -1,7 +1,5 @@
 import React from "react";
 import { connect } from "react-redux";
-import { Position, Switch } from "@blueprintjs/core";
-import { Tooltip2 } from "@blueprintjs/popover2";
 import { FaChevronRight, FaChevronDown } from "react-icons/fa";
 import actions from "../../actions";
 import Gene from "./gene";
@@ -27,7 +25,6 @@ class GeneSet extends React.Component {
     super(props);
     this.state = {
       isOpen: false,
-      toggleSummaryHisto: false,
     };
   }
 
@@ -81,11 +78,6 @@ class GeneSet extends React.Component {
     //   });
   };
 
-  toggleSummaryHisto = () => {
-    const { toggleSummaryHisto } = this.state;
-    this.setState({ toggleSummaryHisto: !toggleSummaryHisto });
-  };
-
   renderGenes() {
     const {
       setName,
@@ -130,8 +122,8 @@ class GeneSet extends React.Component {
 
   render() {
     const { setName, setGenes, genesetDescription } = this.props;
-    const { isOpen, toggleSummaryHisto } = this.state;
-    const genesetNameLengthVisible = 120; /* this magic number determines how much of a long geneset name we see */
+    const { isOpen } = this.state;
+    const genesetNameLengthVisible = 150; /* this magic number determines how much of a long geneset name we see */
     const genesetIsEmpty = setGenes.length === 0;
 
     return (
@@ -184,55 +176,25 @@ class GeneSet extends React.Component {
             )}
           </span>
           <div>
-            <GenesetMenus
-              isOpen={isOpen}
-              toggleSummaryHisto={toggleSummaryHisto}
-              genesetsEditable
-              geneset={setName}
-            />
+            <GenesetMenus isOpen={isOpen} genesetsEditable geneset={setName} />
           </div>
         </div>
 
         <div style={{ marginLeft: 15, marginTop: 5, marginRight: 0 }}>
-          {isOpen && !genesetIsEmpty && (
-            <Tooltip2
-              content="Aggregate all genes in this geneset, and allow coloring by and selecting on the entire set."
-              position={Position.BOTTOM_RIGHT}
-              usePortal
-              hoverOpenDelay={globals.tooltipHoverOpenDelay}
-              modifiers={{
-                preventOverflow: { enabled: false },
-                hide: { enabled: false },
-              }}
-            >
-              <Switch
-                style={{ fontStyle: "italic" }}
-                checked={toggleSummaryHisto}
-                label="Show mean expression across entire set"
-                alignIndicator="left"
-                innerLabel="off"
-                innerLabelChecked="on"
-                onChange={this.toggleSummaryHisto}
-              />
-            </Tooltip2>
-          )}
-
           {isOpen && genesetIsEmpty && (
             <p style={{ fontStyle: "italic", color: "lightgrey" }}>
               No genes to display
             </p>
           )}
         </div>
-        {isOpen &&
-          (!toggleSummaryHisto && !genesetIsEmpty
-            ? this.renderGenes()
-            : setGenes.length > 0 && (
-                <HistogramBrush
-                  isGeneSetSummary
-                  field={setName}
-                  setGenes={setGenes}
-                />
-              ))}
+        {isOpen && !genesetIsEmpty && setGenes.length > 0 && (
+          <HistogramBrush
+            isGeneSetSummary
+            field={setName}
+            setGenes={setGenes}
+          />
+        )}
+        {isOpen && !genesetIsEmpty && this.renderGenes()}
         <EditGenesetNameDialogue
           parentGeneset={setName}
           parentGenesetDescription={genesetDescription}
diff --git a/client/src/components/geneExpression/menus/genesetMenus.js b/client/src/components/geneExpression/menus/genesetMenus.js
index 9082ed68..ecce8b47 100644
--- a/client/src/components/geneExpression/menus/genesetMenus.js
+++ b/client/src/components/geneExpression/menus/genesetMenus.js
@@ -61,20 +61,9 @@ class GenesetMenus extends React.PureComponent {
   };
 
   render() {
-    const {
-      geneset,
-      genesetsEditable,
-      createText,
-      colorAccessor,
-      isOpen,
-      toggleSummaryHisto,
-    } = this.props;
+    const { geneset, genesetsEditable, createText, colorAccessor } = this.props;
 
     const isColorBy = geneset === colorAccessor;
-    const genesetClosed = !isOpen;
-    const showingAllGenes = !toggleSummaryHisto;
-
-    const notShowingSummary = genesetClosed || showingAllGenes;
 
     return (
       <>
@@ -130,12 +119,11 @@ class GenesetMenus extends React.PureComponent {
               />
             </Popover>
             <Tooltip2
-              content={`Color by gene set ${geneset} mean (gene set must be open, and toggled to mean expression histogram)`}
+              content={`Color by gene set ${geneset} mean`}
               position={Position.BOTTOM}
               hoverOpenDelay={globals.tooltipHoverOpenDelay}
             >
               <AnchorButton
-                disabled={notShowingSummary && !isColorBy}
                 active={isColorBy}
                 intent={isColorBy ? "primary" : "none"}
                 style={{ marginLeft: 0 }}