fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-08 19:18:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

Use npm ci instead of npm install during build (#1080)

Browse Source 
Currently the client build is not reproducible since, each time you run
`make build-client` the package lockfile is updated. This should be
handled separately by `make gen-package-lock` when developers actually
want to update the dependencies.

`npm ci` installs dependencies directly from the lockfile without
updating them, making builds reproducible.
This commit is contained in:
Matt Weiden
2020-01-02 10:21:14 -08:00
committed by GitHub
parent 6370025caf
commit 0b1bdca022
2 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Makefile
+2 -2
View File
@@ -27,7 +27,7 @@ build: clean build-server
.PHONY: build-client .PHONY: build-client
build-client: build-client:
cd client && $(MAKE) install build cd client && $(MAKE) ci build
.PHONY: build-server .PHONY: build-server
build-server: build-client build-server: build-client
@@ -122,7 +122,7 @@ release-directly-to-prod: dev-env pydist twine-prod
.PHONY: dev-env .PHONY: dev-env
dev-env: dev-env:
cd client && $(MAKE) install cd client && $(MAKE) ci
pip install -r server/requirements-dev.txt pip install -r server/requirements-dev.txt
.PHONY: gui-env .PHONY: gui-env
client/Makefile
+4
View File
@@ -2,6 +2,10 @@
clean: clean:
rm -rf node_modules rm -rf node_modules
.PHONY: ci
ci:
npm ci client
.PHONY: install .PHONY: install
install: install:
npm install client npm install client