From 0d2cb147967cc3a1222293cac6bf587a5ef98ed4 Mon Sep 17 00:00:00 2001 From: Matt Weiden <538456+mweiden@users.noreply.github.com> Date: Thu, 2 Jan 2020 16:32:00 -0800 Subject: [PATCH] Fix smoke test instructions (#1087) --- dev_docs/developer_guidelines.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/dev_docs/developer_guidelines.md b/dev_docs/developer_guidelines.md index d2951f05..3a85ed3f 100644 --- a/dev_docs/developer_guidelines.md +++ b/dev_docs/developer_guidelines.md @@ -29,17 +29,16 @@ End to end tests use two env variables: On CI the end to end tests are run with `JEST_ENV` set to `prod` using the `smoke-test` make target. -To run end to end tests as they will be run on CI -1. cellxgene should be built and installed as [specified in server dev](#install) -2. `export JEST_ENV='prod'` -3. `export JEST_CXG_PORT=5000` -4. Run `npm run --prefix client/ smoke-test` +To run end to end tests as they will be run on CI use the following command: +``` +JEST_ENV=prod JEST_CXG_PORT=5000 make pydist install-dist dev-env smoke-test +``` Run end to end tests interactively during development 1. cellxgene should be installed as [specified in client dev](#install-1) -2. Follow [launch](#launch-1) instructions for client dev with dataset `example-dataset/pbmc3k` -3. Run `make smoke-test` -4. To debug a failing test `export JEST_ENV='debug'` and re-run. +1. Follow [launch](#launch-1) instructions for client dev with dataset `example-dataset/pbmc3k` +1. Run `npm run e2e` or `make e2e` from the `client` directory +1. To debug a failing test `export JEST_ENV='debug'` and re-run. ## Server dev ### Install