Redux refactor (#1571)

* refactor categorical controls state

* lint

* fix race condition in tests

* fix typo

* add missing update on subset

* remove obsolete code

* update jest and puppeteer major version; update all minors

* update when label changes

* remove lint from tests; increase timeouts in e2e tests

* initial refactoring to new async annomatrix

* refine error handling

* fix bad merge

* add continuous legend

* lint

* fix memoization in color table creators

* partial implementation of user defined annotations

* add new annotations action creator file

* first pass at user annotations

* additional user annotation bug fixes

* user annotation auto-save

* unit test cleanup

* lint

* refactor into multiple files

* cleanup

* add column GC

* fix several bugs in user annotations

* remove debug code

* no anonymous functions

* undo redo cleanup

* file cleanup

* scatterplot

* performance

* cleanup

* remove old code

* render in parallel with load

* fix race condition

* simply graph rendering

* render throttle DRY

* fix category label order

* fix typo in e2e test setup

* re-fix the e2e test setup

* be more tolerant of races

* anno matrix unit tests

* temp disable reembedding

* pilot port continuous histo to react-async

* name change

* lint

* fix repaint bug

* typo fix

* update snap to match new ids

* world/universe name cleanup

* move annoMatrix to src dir

* use private underscore naming convention

* fix corner case in all selected

* name cleanup

* add layout control

* init edge case

* lint

* port scatterplot

* fix label indexing bug and improve tests

* port category to react-async

* fix user annotation labelling while subset

* select all of prev layout on layout switch

* fix race with crossfilter update

* prettier lint

* fix misleading comment

* fix url composition in loader

* first pass at crossfilter tests

* lint

* lint

* fix typo

* improved error handling for network errors

* fix memoization bug

* add memo

* refactor for performnce

* add missing single-value handling in select exact parser

* small bugs discovered by tests

* lint

* additional crossfilter unit tests

* remove extraneous comment

* add support for automatic category determination

* lint

* fix render bug in category

* take advantage of schema categories guarantee

* lint

* do not clear history when resetting

* enhanced annomatrix gc

* lint

* finish renaming to follow conventions; fix clone race bug

* lint

* add priority based loading to improve initial data load UX

* crossfilter cache perf

* perf tuning

* remove timers

* documentation

* PR review changes

* PR review changes

* more PR review edits

* improve clarity of comment

* more PR review fixes

* port centroidLabels to use react-async

* remove dead code

* pr review updates

* oops, remove logging

client/src/components/continuous/continuous.js

@@ -1,97 +1,28 @@
-// jshint esversion: 6
 /* rc slider https://www.npmjs.com/package/rc-slider */
 
 import React from "react";
 import { connect } from "react-redux";
-import { Button } from "@blueprintjs/core";
-
-import * as globals from "../../globals";
 import HistogramBrush from "../brushableHistogram";
 
 @connect((state) => ({
-  obsAnnotations: state.world?.obsAnnotations,
-  colorAccessor: state.colors.colorAccessor,
-  colorScale: state.colors.scale,
-  schema: state.world?.schema,
+  schema: state.annoMatrix?.schema,
 }))
 class Continuous extends React.PureComponent {
-  static renderIsStillLoading(zebra, key) {
-    return (
-      <div
-        key={key}
-        style={{
-          padding: globals.leftSidebarSectionPadding,
-          backgroundColor: zebra % 2 === 0 ? globals.lightestGrey : "white",
-        }}
-      >
-        <div
-          style={{
-            display: "flex",
-            justifyContent: "space-between",
-            justifyItems: "center",
-            alignItems: "center",
-          }}
-        >
-          <div style={{ minWidth: 30 }} />
-          <div style={{ display: "flex", alignSelf: "center" }}>
-            <span style={{ fontStyle: "italic" }}>{key}</span>
-          </div>
-          <div
-            style={{
-              display: "flex",
-              justifyContent: "flex-end",
-            }}
-          >
-            <Button minimal loading intent="primary" />
-          </div>
-        </div>
-      </div>
-    );
-  }
-
   render() {
-    const { obsAnnotations, schema } = this.props;
-
+    /* initial value for iterator to simulate index, ranges is an object */
+    const { schema } = this.props;
+    if (!schema) return null;
     const obsIndex = schema.annotations.obs.index;
     const allContinuousNames = schema.annotations.obs.columns
       .filter((col) => col.type === "int32" || col.type === "float32")
       .filter((col) => col.name !== obsIndex)
       .map((col) => col.name);
 
-    /* initial value for iterator to simulate index, ranges is an object */
-    let zebra = 0;
-
     return (
       <div>
-        {allContinuousNames.map((key) => {
-          if (!obsAnnotations.hasCol(key)) {
-            // still loading!
-            zebra += 1;
-            return Continuous.renderIsStillLoading(zebra, key);
-          }
-
-          // data loaded and available
-          const summary = obsAnnotations.col(key).summarize();
-          const nonFiniteExtent =
-            summary.min === undefined ||
-            summary.max === undefined ||
-            Number.isNaN(summary.min) ||
-            Number.isNaN(summary.max);
-          if (!summary.categorical && !nonFiniteExtent) {
-            zebra += 1;
-            return (
-              <HistogramBrush
-                key={key}
-                field={key}
-                isObs
-                zebra={zebra % 2 === 0}
-                ranges={summary}
-              />
-            );
-          }
-
-          return null;
-        })}
+        {allContinuousNames.map((key, zebra) => (
+          <HistogramBrush key={key} field={key} isObs zebra={zebra % 2 === 0} />
+        ))}
       </div>
     );
   }