mirror of
https://github.com/chanzuckerberg/cellxgene.git
synced 2026-10-02 22:28:11 +08:00
differential expression improvements (#452)
* add cutoff for low expression genes in topN selection * remove debugging printfs * change cli param name for diffexp cutoff * change CLI param name * second try at diffexp - using lfc sort with pval cutoff * use lfc cutoff * update comments to match code; cap p-value adjustment to max of 1 * lint * explain diffexp in readme * add link * add diffexp-lfc-cutoff to test config * update test to match revised diffexp spec * fix latent bug in GET arg handling that was breaking tests * lint * comment cleanup * fix variance overestimation so it is symmetric * lint
This commit is contained in:
committed by
Charlotte Weaver
parent
3475f3f12e
commit
141f802824
@@ -14,7 +14,7 @@ from server.app.scanpy_engine.scanpy_engine import ScanpyEngine
|
||||
class UtilTest(unittest.TestCase):
|
||||
def setUp(self):
|
||||
args = {'layout': 'umap', 'diffexp': 'ttest', 'max_category_items': 100,
|
||||
'obs_names': None, 'var_names': None}
|
||||
'obs_names': None, 'var_names': None, 'diffexp_lfc_cutoff': 0.01}
|
||||
|
||||
self.data = ScanpyEngine("example-dataset/pbmc3k.h5ad", args)
|
||||
self.data._create_schema()
|
||||
@@ -201,8 +201,6 @@ class UtilTest(unittest.TestCase):
|
||||
}
|
||||
result = self.data.diffexp_topN(f1["filter"], f2["filter"])
|
||||
self.assertEqual(len(result), 10)
|
||||
var_idx = [i[0] for i in result]
|
||||
self.assertEqual(var_idx, sorted(var_idx))
|
||||
result = self.data.diffexp_topN(f1["filter"], f2["filter"], 20)
|
||||
self.assertEqual(len(result), 20)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user