fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-02 12:48:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

Disable ColorBy button for truncated categories (#1191)

Browse Source 
* Disable ColorBy button for truncated categories

Fixes https://github.com/chanzuckerberg/cellxgene/issues/1156

For categories that have more than 100 labels we truncate the labels in
the UI, but still allowed users to ColorBy these categories. Coloring by
these categories can cause browsers to get bogged down.

This commit disables ColorBy for truncated categories.

* Minor documentation spelling and typo fixes

* Respond to feedback from @liaprins-czi

* Respond to feedback from @colinmegill and @bkmartinjr
This commit is contained in:
Matt Weiden
2020-03-04 09:19:12 -08:00
committed by GitHub
parent 05323ae643
commit 1547a864c2
4 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/util/stateManager/controlsHelpers.js
+1 -1
View File
@@ -45,7 +45,7 @@ Remember that option values can be ANY js type, except undefined/null.
}
*/
function topNCategories(colSchema, summary, N) {
/* return top N by occurance in the data, preserving original category order */
/* return top N by occurrences in the data, preserving original category order */
const { categories } = colSchema;
const counts = categories.map(cat => summary.categoryCounts.get(cat) ?? 0);