mirror of
https://github.com/chanzuckerberg/cellxgene.git
synced 2026-09-26 06:38:12 +08:00
Use sci notation for axis ticks abs(tick) >= 10000 (#1363)
Fixes https://github.com/chanzuckerberg/cellxgene/issues/1349 For more information see https://github.com/d3/d3-format Note that does not _fully_ fix the issue described in #1349, but rather makes the formatting issue far less likely. It is _still_ possible for this to occur if the difference between two ticks in axes happes in the a significant digit cropped by the scientific notation format
This commit is contained in:
@@ -80,8 +80,8 @@ class HistogramBrush extends React.PureComponent {
|
||||
constructor(props) {
|
||||
super(props);
|
||||
|
||||
this.marginLeft = 3; // Space for 0 tick label on X axis
|
||||
this.marginRight = 40; // space for Y axis & labels
|
||||
this.marginLeft = 12; // Space for 0 tick label on X axis
|
||||
this.marginRight = 52; // space for Y axis & labels
|
||||
this.marginBottom = 25; // space for X axis & labels
|
||||
this.marginTop = 3;
|
||||
|
||||
@@ -374,8 +374,8 @@ class HistogramBrush extends React.PureComponent {
|
||||
.call(
|
||||
d3
|
||||
.axisBottom(x)
|
||||
.ticks(5)
|
||||
.tickFormat(d3.format(".0s"))
|
||||
.ticks(4)
|
||||
.tickFormat(d3.format(x.domain().some(n => Math.abs(n) >= 10000) ? ".2e" : ","))
|
||||
);
|
||||
|
||||
/* Y AXIS */
|
||||
@@ -387,7 +387,7 @@ class HistogramBrush extends React.PureComponent {
|
||||
d3
|
||||
.axisRight(y)
|
||||
.ticks(3)
|
||||
.tickFormat(d3.format(".0s"))
|
||||
.tickFormat(d3.format(y.domain().some(n => Math.abs(n) >= 10000) ? ".0e" : ","))
|
||||
);
|
||||
|
||||
/* axis style */
|
||||
|
||||
Reference in New Issue
Block a user