fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-05 06:48:12 +08:00
Code Issues Packages Projects Releases Wiki Activity

[WIP DO NOT MERGE] suppress display of continous annotation without a finite extent (#618)

Browse Source 
* initial dataframe commit

* initial dataframe port of core app

* rename variables for clarity

* remove unused import

* comment out unused code

* fix array handling bug in crossfilter dimension creation

* allow creation of empty dataframes

* handle non-existent columns

* handle non-existent columns

* revise tests for new dataframe

* comments for clarity

* comments for clarity

* generate bulk add placeholder with real gene names

* fix bug in gene name adding

* more dataframe unit tests

* fix bug - subset from current world, not universe

* put cut and pasted code into a single function

* improve caching of crossfilter

* remove cascading update bug from graph

* more performance work

* improve state handling for scatterplot

* performance optimization of critical path

* add column summarization

* dataframe utils

* add callOnceLazy

* fix tests

* minor updates found during review

* fix misspelling

* remove RESTv02 from function names

* comment cleanup

* cut/icut col parameter defaults to null

* break up large test

* improve tests and comments on dataframe at/has functions

* add Dataframe withCol/dropCol

* expression varData now stored in a dataframe

* dead code cleanup

* use dataframe.summarize()

* test cases for Dataframe.col.summarize

* update test cases for new dataframe summarize

* improve naming

* use new hasCol API

* add comments

* add more Dataframe.withCol tests

* add ability to specify row index in cut operation

* retire subsetVarData function

* correctly handle expression subsetting

* lint and improve comments

* rename cut to subset

* suppress display of continous annotation withont a finite extent

* fix botched merge

* more fix of botched merged
This commit is contained in:
Bruce Martin
2019-02-28 09:05:48 -08:00
committed by GitHub
parent ffd6273419
commit 2f1facaafb
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/components/continuous/continuous.js
+8 -1
View File
@@ -68,8 +68,15 @@ class Continuous extends React.Component {
const summary = obsAnnotations.col(key).summarize(); const summary = obsAnnotations.col(key).summarize();
const isColorField = const isColorField =
key.includes("color") || key.includes("Color"); key.includes("color") || key.includes("Color");
const nonFiniteExtent =
summary.min === undefined || summary.max === undefined;
zebra += 1; zebra += 1;
if (!summary.categorical && key !== "name" && !isColorField) { if (
!summary.categorical &&
key !== "name" &&
!isColorField &&
!nonFiniteExtent
) {
return ( return (
<HistogramBrush <HistogramBrush
key={key} key={key}