From 4117050081abc6cd2bf177bacc8c4ee73a3297cc Mon Sep 17 00:00:00 2001 From: Matt Weiden <538456+mweiden@users.noreply.github.com> Date: Fri, 3 Apr 2020 15:09:54 -0700 Subject: [PATCH] `make install` should fail if there's no build dir (#1344) Currently, if there is no build directory, the `make install` target will attempt to cd into the build directory, fail, and run pip install -e . in the root directory anyway. This causes cellxgene to be installed from the source tree instead of what the user would expect. This commit changes the behavior such that the `make install` will fail if there is no build directory. --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 70e89531..3ba6d7f5 100644 --- a/Makefile +++ b/Makefile @@ -151,7 +151,7 @@ gen-package-lock: # install from build directory .PHONY: install install: uninstall - cd $(BUILDDIR); pip install -e . + cd $(BUILDDIR) && pip install -e . # install from source tree for development .PHONY: install-dev