fix race condition in test_oauth (#1956)

This commit is contained in:
bmccandless
2020-10-29 11:05:23 -07:00
committed by GitHub
parent 727af83152
commit 6a1e5f71be
3 changed files with 11 additions and 10 deletions

View File

@@ -129,9 +129,9 @@ def can_cast_to_int32(dtype, array_values=None):
return True
ii32 = np.iinfo(np.int32)
if (
not ordered_array_values.empty
and (ordered_array_values.min() >= ii32.min and ordered_array_values.max() <= ii32.max)
or ordered_array_values.empty
not ordered_array_values.empty
and (ordered_array_values.min() >= ii32.min and ordered_array_values.max() <= ii32.max)
or ordered_array_values.empty
):
return True
return False

View File

@@ -73,13 +73,15 @@ def launch_mock_oauth():
class AuthTest(unittest.TestCase):
def setUp(self):
self.dataset_dataroot = FIXTURES_ROOT
self.mock_oauth_process = Process(target=launch_mock_oauth)
self.mock_oauth_process.start()
@classmethod
def setUpClass(cls):
cls.dataset_dataroot = FIXTURES_ROOT
cls.mock_oauth_process = Process(target=launch_mock_oauth)
cls.mock_oauth_process.start()
def tearDown(self):
self.mock_oauth_process.terminate()
@classmethod
def tearDownClass(cls):
cls.mock_oauth_process.terminate()
def auth_flow(self, app_config, cookie_key=None):

View File

@@ -20,7 +20,6 @@ class CLIPLaunchTests(unittest.TestCase):
def tearDownClass(cls) -> None:
shutil.rmtree(cls.tmp_dir)
def test_dump_default_config(self):
os.system(f"cellxgene launch --dump-default-config > {self.tmp_dir}/test_config_dump.txt")
with open(f"{self.tmp_dir}/expected_config_dump.txt", "w") as expected_config: