re-implement re-embeddings (#1679)

* fix mispelling

* re-implement re-embedding

* always load base embedding to fetch counts

* format

* lint

* fix tests

* lint

* fix accept handling

* test log

* more debug

* more

* more

* more

* more

* remove logging

* logging

* jsonify

* remove debugging logs

* lint

* clean up errors a bit

* fix issue found in PR review

* PR review changes

client/src/components/embedding/index.js

@@ -101,7 +101,7 @@ export default Embedding;
 
 const loadAllEmbeddingCounts = async ({ annoMatrix, available }) => {
   const embeddings = await Promise.all(
-    available.map((name) => annoMatrix.fetch("emb", name))
+    available.map((name) => annoMatrix.base().fetch("emb", name))
   );
   return available.map((name, idx) => ({
     embeddingName: name,

client/src/components/menubar/index.js

@@ -10,6 +10,7 @@ import InformationMenu from "./infoMenu";
 import Subset from "./subset";
 import UndoRedoReset from "./undoRedo";
 import DiffexpButtons from "./diffexpButtons";
+import Reembedding from "./reembedding";
 import { getEmbSubsetView } from "../../util/stateManager/viewStackHelpers";
 
 @connect((state) => {
@@ -49,6 +50,8 @@ import { getEmbSubsetView } from "../../util/stateManager/viewStackHelpers";
     tosURL: state.config?.parameters?.["about_legal_tos"],
     privacyURL: state.config?.parameters?.["about_legal_privacy"],
     categoricalSelection: state.categoricalSelection,
+    enableReembedding:
+      state.config?.parameters?.["enable-reembedding"] ?? false,
   };
 })
 class MenuBar extends React.PureComponent {
@@ -214,6 +217,7 @@ class MenuBar extends React.PureComponent {
       colorAccessor,
       subsetPossible,
       subsetResetPossible,
+      enableReembedding,
     } = this.props;
     const { pendingClipPercentiles } = this.state;
 
@@ -266,6 +270,7 @@ class MenuBar extends React.PureComponent {
             this.handleClipPercentileMinValueChange
           }
         />
+        {enableReembedding ? <Reembedding /> : null}
         <Tooltip
           content="When a category is colored by, show labels on the graph"
           position="bottom"

client/src/components/menubar/reembedding.js

@@ -0,0 +1,40 @@
+import React from "react";
+import { connect } from "react-redux";
+import { AnchorButton, ButtonGroup, Tooltip } from "@blueprintjs/core";
+import * as globals from "../../globals";
+import actions from "../../actions";
+import styles from "./menubar.css";
+
+@connect((state) => ({
+  reembedController: state.reembedController,
+  annoMatrix: state.annoMatrix,
+}))
+class Reembedding extends React.PureComponent {
+  render() {
+    const { dispatch, annoMatrix, reembedController } = this.props;
+    const loading = !!reembedController?.pendingFetch;
+    const disabled = annoMatrix.nObs === annoMatrix.schema.dataframe.nObs;
+    const tipContent = disabled
+      ? "Subset cells first, then click to recompute UMAP embedding."
+      : "Click to recompute UMAP embedding on the current cell subset.";
+
+    return (
+      <ButtonGroup className={styles.menubarButton}>
+        <Tooltip
+          content={tipContent}
+          position="bottom"
+          hoverOpenDelay={globals.tooltipHoverOpenDelay}
+        >
+          <AnchorButton
+            icon="new-object"
+            disabled={disabled}
+            onClick={() => dispatch(actions.requestReembed())}
+            loading={loading}
+          />
+        </Tooltip>
+      </ButtonGroup>
+    );
+  }
+}
+
+export default Reembedding;