fork/cellxgene
1
0
Fork 0
mirror of https://github.com/chanzuckerberg/cellxgene.git synced 2026-10-01 04:38:11 +08:00
Code Issues Packages Projects Releases Wiki Activity

undo/redo cleanup (#1165)

Browse Source 
* fix refactoring error which disabled annotation file clearing

* fix undo behavior on add category label

* fix various undo/redo bugs

* remove logging

* further refinement of annotation undo/redo and actions

* address PR comment
This commit is contained in:
Bruce Martin
2020-02-24 18:51:26 -07:00
committed by GitHub
parent 5c70cc5bcd
commit 7bc58bba2b
10 changed files with 75 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/src/reducers/undoableConfig.js
+26 -10
View File
@@ -35,18 +35,30 @@ const skipOnActions = new Set([
"get single gene expression for coloring error",
"category value mouse hover start",
"category value mouse hover end"
"category value mouse hover end",
/* autosave annotations */
"writable obs annotations - save complete",
"writable obs annotations - save started",
"writable obs annotations - save error",
/* annotation component action */
"annotation: activate add new label mode",
"annotation: activate add new ontology label mode",
"annotation: disable add new ontology label mode",
"annotation: disable add new label mode",
"annotation: activate category edit mode",
"annotation: disable category edit mode",
"annotation: activate edit label mode",
"annotation: cancel edit label mode",
"set annotations collection name"
]);
/*
identical, repeated occurances of these action types will be debounced.
Entire action must be identical (all keys).
*/
const debounceOnActions = new Set([
"color by categorical metadata",
"color by continuous metadata",
"color by expression"
]);
const debounceOnActions = new Set([]);
/*
history will be cleared when these actions occur
@@ -91,7 +103,8 @@ const saveOnActions = new Set([
"annotation: delete category",
"annotation: label edited",
"annotation: label current cell selection",
"annotation: delete label"
"annotation: delete label",
"annotation: category edited"
]);
/**
@@ -172,8 +185,6 @@ const actionFilter = debug => (state, action, prevFilterState) => {
}
if (
debounceOnActions.has(actionType) &&
prevFilterState !== undefined &&
prevFilterState.prevAction !== undefined &&
shallowObjectEq(action, prevFilterState.prevAction)
) {
return { [actionKey]: "skip", [stateKey]: filterState };
@@ -229,7 +240,12 @@ function shallowArrayEq(arrA, arrB) {
}
/* configuration for the undoable meta reducer */
const debug = false; // set truish for undoble debugging
/*
debug: set to any falsish value to disable logging of helpful debugging information.
Set to true or 1 for base logging, high number for more verbosity (currently only 1/true
or 2).
*/
const debug = false;
const undoableConfig = {
debug,
historyLimit: 50, // maximum history size